Conversation
Karolk99
force-pushed
the
hls-postprocessing
branch
from
e1a4d1b to
8192431
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
==========================================
- Coverage 86.24% 86.23% -0.01%
==========================================
Files 50 52 +2
Lines 923 966 +43
==========================================
+ Hits 796 833 +37
- Misses 127 133 +6
Continue to review full report in Codecov by Sentry.
|
mickel8
suggested changes
Nov 9, 2023
Rados13
reviewed
Nov 9, 2023
mickel8
approved these changes
Nov 9, 2023
Rados13
reviewed
Nov 10, 2023
| end | ||
|
|
||
| maybe_remove_hls(state.hls_options, state.hls_dir) | ||
| unless is_nil(hls_options.s3), do: upload_to_s3(hls_dir, room_id, hls_options.s3) |
Contributor
There was a problem hiding this comment.
Shouldn't that work?
Suggested change
| unless is_nil(hls_options.s3), do: upload_to_s3(hls_dir, room_id, hls_options.s3) | |
| if hls_options.s3, do: upload_to_s3(hls_dir, room_id, hls_options.s3) |
Rados13
reviewed
Nov 10, 2023
Comment on lines
+383
to
+390
| defp wait_for_folder(hls_dir, milliseconds) do | ||
| if File.exists?(hls_dir) do | ||
| :ok | ||
| else | ||
| Process.sleep(100) | ||
| wait_for_folder(hls_dir, milliseconds - 100) | ||
| end | ||
| end |
Contributor
There was a problem hiding this comment.
Do we really need this? Couldn't we rely on some notifications etc?
Contributor
Author
There was a problem hiding this comment.
Element responsible for creating this folder is HLS endpoint so this is a tough one. I will look at it again.
Contributor
Author
There was a problem hiding this comment.
It's impossible right now because file creation has to happen before engine termination
This was referenced Nov 10, 2023
mickel8
reviewed
Nov 14, 2023
| defp remove_hls(hls_dir, room_id) do | ||
| File.rm_rf!(hls_dir) | ||
| Logger.info("Remove hls from local memory, room: #{inspect(room_id)}") | ||
| Logger.info("Remove hls from local memory, room: #{room_id}") |
Contributor
There was a problem hiding this comment.
Please write from a disk as local memory sounds like RAM
| options: options | ||
| } do | ||
| create_expect(0) | ||
| pid = start_process() |
Contributor
There was a problem hiding this comment.
start_process, kill_process and create_expect are a bit generic names
Rados13
reviewed
Nov 14, 2023
Rados13
approved these changes
Nov 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acknowledging the stipulations set forth: