Skip to content

HLS: subscribe for peers and components instead of specific tracks#45

Merged
Karolk99 merged 3 commits intomasterfrom
subscirbe-for-endpoints
Dec 19, 2023
Merged

HLS: subscribe for peers and components instead of specific tracks#45
Karolk99 merged 3 commits intomasterfrom
subscirbe-for-endpoints

Conversation

@Karolk99
Copy link
Copy Markdown
Contributor

@Karolk99 Karolk99 requested a review from mickel8 December 14, 2023 16:47
Comment thread lib/jellyfish/notification.ex
Comment thread lib/jellyfish/room.ex
@Karolk99 Karolk99 requested a review from mickel8 December 14, 2023 17:53
Comment thread lib/jellyfish/room.ex
Comment on lines 244 to 249
@doc """
Adds peers and components tracks to hls component
In order to subscribe to HLS peers/components, the HLS component should be initialized with the subscribe_mode set to :manual.
This mode proves beneficial when you do not wish to record or stream all the available streams within a room via HLS.
It allows for selective addition instead – you can manually select specific streams.
For instance, you could opt to record only the stream of an event's host.
"""
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add one intro sentence as they are displayed in summary

@Karolk99 Karolk99 merged commit 2a50f72 into master Dec 19, 2023
@Karolk99 Karolk99 deleted the subscirbe-for-endpoints branch December 19, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants