HLS: subscribe for peers and components instead of specific tracks#131
Merged
HLS: subscribe for peers and components instead of specific tracks#131
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #131 +/- ##
==========================================
- Coverage 86.94% 86.93% -0.02%
==========================================
Files 58 58
Lines 1057 1056 -1
==========================================
- Hits 919 918 -1
Misses 138 138
Continue to review full report in Codecov by Sentry.
|
mickel8
approved these changes
Dec 14, 2023
| items: Track | ||
| description: | ||
| "List of peers and components whose tracks the HLS endpoint will subscribe to", | ||
| items: Origin |
Contributor
There was a problem hiding this comment.
I would just convert this to string. Also module name needs an update
| @@ -5,25 +5,126 @@ | |||
| components: | |||
Contributor
There was a problem hiding this comment.
Pretty weird that there are so many changes but I checked and this is indeed how openapi.yaml is generated on this branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acknowledging the stipulations set forth: