Skip to content

HLS: subscribe for peers and components instead of specific tracks#131

Merged
Karolk99 merged 4 commits intomainfrom
subscribe-for-enpdoints
Dec 14, 2023
Merged

HLS: subscribe for peers and components instead of specific tracks#131
Karolk99 merged 4 commits intomainfrom
subscribe-for-enpdoints

Conversation

@Karolk99
Copy link
Copy Markdown
Contributor

Acknowledging the stipulations set forth:

  • I hereby confirm that a Pull Request involving updates to the Software Development Kit (SDK) has been smoothly merged, currently awaits processing, or is otherwise deemed unnecessary in this context.
  • I also affirm that another Pull Request, specifically addressing updates to the documentation body (commonly referred to as 'docs'), has either been successfully incorporated, is in the process of review, or is considered superfluous under the prevailing circumstances.

@Karolk99 Karolk99 requested a review from mickel8 December 14, 2023 16:17
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 14, 2023

Codecov Report

Merging #131 (f20caad) into main (76f4d48) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
- Coverage   86.94%   86.93%   -0.02%     
==========================================
  Files          58       58              
  Lines        1057     1056       -1     
==========================================
- Hits          919      918       -1     
  Misses        138      138              
Files Coverage Δ
lib/jellyfish/room.ex 86.87% <100.00%> (ø)
lib/jellyfish_web/api_spec/subscription.ex 100.00% <ø> (ø)
...llyfish_web/controllers/subscription_controller.ex 88.88% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76f4d48...f20caad. Read the comment docs.

items: Track
description:
"List of peers and components whose tracks the HLS endpoint will subscribe to",
items: Origin
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just convert this to string. Also module name needs an update

Comment thread openapi.yaml
@@ -5,25 +5,126 @@
components:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty weird that there are so many changes but I checked and this is indeed how openapi.yaml is generated on this branch

@Karolk99 Karolk99 marked this pull request as ready for review December 14, 2023 17:01
@Karolk99 Karolk99 merged commit 6c2f2cb into main Dec 14, 2023
@Karolk99 Karolk99 deleted the subscribe-for-enpdoints branch December 14, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants