Skip to content

ci: Use ubuntu 26.04 container#738

Draft
bbhtt wants to merge 10 commits into
mainfrom
bbhtt/ci-container
Draft

ci: Use ubuntu 26.04 container#738
bbhtt wants to merge 10 commits into
mainfrom
bbhtt/ci-container

Conversation

@bbhtt
Copy link
Copy Markdown
Contributor

@bbhtt bbhtt commented May 16, 2026

Needed for new dependencies like appstream, GitHub is yet to make actions-images available for 26.04

Needed for new dependencies like appstream, GitHub is yet to make
actions-images available for 26.04
@bbhtt bbhtt force-pushed the bbhtt/ci-container branch from b3b422e to 4c38469 Compare May 16, 2026 05:36
@bbhtt
Copy link
Copy Markdown
Contributor Author

bbhtt commented May 16, 2026

../src/builder-flatpak-utils.c: In function ‘flatpak_path_match_prefix’:
../src/builder-flatpak-utils.c:188:27: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  188 |               char *tmp = strchr (string, '/');
      |                           ^~~~~~
../src/builder-flatpak-utils.c: In function ‘get_xdg_user_dir_from_string’:
../src/builder-flatpak-utils.c:1641:9: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
 1641 |   slash = strchr (filesystem, '/');
      |         ^
../src/builder-flatpak-utils.c: In function ‘option_add_generic_policy_cb’:
../src/builder-flatpak-utils.c:2094:5: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
 2094 |   t = strchr (value, '=');
      |     ^
../src/builder-flatpak-utils.c: In function ‘option_remove_generic_policy_cb’:
../src/builder-flatpak-utils.c:2122:5: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
 2122 |   t = strchr (value, '=');
      |   
/usr/include/ostree-1/ostree-content-writer.h:28:23: warning: redefinition of typedef 'OstreeContentWriter' is a C11 feature [-Wtypedef-redefinition]
   28 | G_DECLARE_FINAL_TYPE (OstreeContentWriter, ostree_content_writer, OSTREE, CONTENT_WRITER,
      |                       ^
/usr/include/ostree-1/ostree-types.h:39:37: note: previous definition is here
   39 | typedef struct _OstreeContentWriter OstreeContentWriter;
      |                                     ^
../src/builder-flatpak-utils.c:188:21: error: initializing 'char *' with an expression of type 'const char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
  188 |               char *tmp = strchr (string, '/');
      |                     ^     ~~~~~~~~~~~~~~~~~~~~
../src/builder-flatpak-utils.c:1641:9: error: assigning to 'char *' from 'const char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
 1641 |   slash = strchr (filesystem, '/');
      |         ^ ~~~~~~~~~~~~~~~~~~~~~~~~
../src/builder-flatpak-utils.c:2094:5: error: assigning to 'char *' from 'const char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
 2094 |   t = strchr (value, '=');
      |     ^ ~~~~~~~~~~~~~~~~~~~
../src/builder-flatpak-utils.c:2122:5: error: assigning to 'char *' from 'const char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
 2122 |   t = strchr (value, '=');
      |     ^ ~~~~~~~~~~~~~~~~~~~
1 warning and 4 errors generated.

edit. split to #739

Glibc 2.43 implements C23 const-preserving string-search functions [1]

This fixes the build with Glibc 2.43 and GCC 15.1 (which defaults
to C23).

[1]: https://sourceware.org/glibc/wiki/Release/2.43#C23_Const-Preserving_Standard_Library_Macros_May_Break_Some_Packages
@bbhtt bbhtt marked this pull request as draft May 16, 2026 05:51
Only for non-wrap path as upstream projects in wraps are unmaintained
@bbhtt bbhtt force-pushed the bbhtt/ci-container branch from 2f45db5 to b6cd2e6 Compare May 16, 2026 05:56
bbhtt added 6 commits May 16, 2026 12:45
Fixes Wattribute-warning when building with clang
Screencasts are generally unwanted in catalogue to as they are more
expensive to download, store in ref and serve. Also no appstore
currently supports showing them. This can later be changed if needed.
This allows all `<custom>` tags from metainfo files to reach
catalogue data. Custom tags are used by Flathub to store verification
and build information and often downstream vendors who use Flathub's
catalogue for their own app store want custom tags to identify or
highlight their own apps. For example cosmic using Flathub catalogue
data to highlight cosmic apps on cosmic store app etc.

Allowing individual custom tags one by one is annoying and this is what
libappstream-glib did before the port in 1.3.4. So this brings back
the old as-glib behaviour that was lost in >=1.3.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant