Skip to content

builder-flatpak-utils: Fix const correctness warnings#739

Open
bbhtt wants to merge 1 commit into
mainfrom
bbhtt/const-fixes
Open

builder-flatpak-utils: Fix const correctness warnings#739
bbhtt wants to merge 1 commit into
mainfrom
bbhtt/const-fixes

Conversation

@bbhtt
Copy link
Copy Markdown
Contributor

@bbhtt bbhtt commented May 16, 2026

Glibc 2.43 implements C23 const-preserving string-search functions 1

This fixes the build with Glibc 2.43 and GCC 15.1 (which defaults to C23).

../src/builder-flatpak-utils.c:188:21: error: initializing 'char *' with an expression of type 'const char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
  188 |               char *tmp = strchr (string, '/');
      |                     ^     ~~~~~~~~~~~~~~~~~~~~
../src/builder-flatpak-utils.c:1641:9: error: assigning to 'char *' from 'const char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
 1641 |   slash = strchr (filesystem, '/');
      |         ^ ~~~~~~~~~~~~~~~~~~~~~~~~
../src/builder-flatpak-utils.c:2094:5: error: assigning to 'char *' from 'const char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
 2094 |   t = strchr (value, '=');
      |     ^ ~~~~~~~~~~~~~~~~~~~
../src/builder-flatpak-utils.c:2122:5: error: assigning to 'char *' from 'const char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
 2122 |   t = strchr (value, '=');
      |     ^ ~~~~~~~~~~~~~~~~~~~
1 warning and 4 errors generated.

Glibc 2.43 implements C23 const-preserving string-search functions [1]

This fixes the build with Glibc 2.43 and GCC 15.1 (which defaults
to C23).

[1]: https://sourceware.org/glibc/wiki/Release/2.43#C23_Const-Preserving_Standard_Library_Macros_May_Break_Some_Packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant