Tracking: Performance Issues

[JaffaKetchup]

This issue aims to help track the multiple performance issues, so it's easier to handle them by linking them together, fixing them, or closing them.

• Performance issues and fatal crashes caused by WMS layer #1161
• Polyline Layer causing crashes when panning map #1154
• Marker calulations are heavy #958

There are likely to be more added in the future.

---

Fixed/ignored (closed) issues:

• The map is lagged when the polyline consists of a large number of points #1107
• [BUG] Polylines lagging after upgrading from Flutter 2.5 to 2.10 #1217
• [BUG] TileLayer lag/jitter #1245

[grahamsmith]

Hello 👋 I am new to the repo so apologies if this is not the right place. Thanks for all the hard work thus far 👍

I have been reading through the code and having a play and noticed there are some performance improvements that could be made. I then noticed this issue.

Unsure if you are accepting PRs but would be happy to help. For example I have noticed we work with num a lot when in practice we parse from String to Double and then treat is as a num in the middle and then cast it via toDouble() at the end. Whilst individually probably not that expensive it probably adds up over time.

The WMS implementation looks like it has caused some ripple effects through the code too, for example when dealing with urlTemplate and then having to force unwrap it etc. I've seen notes in the code so I'm late to this party.

I think there's some general widget improvements (removing un-needed ones) and some newer language features to help out too.

Happy to help but didn't want to waste my time either if its not needed.

[ibrierley]

Help is always wanted :), and all suggestions and PRs welcome ! So feel free and great to have others interested.

Whilst all optimisations welcome, I would also say as a general programming thing, I wouldn't get too hung up on microoptimisations and let it eat up your previous dev time, there are normally bigger fish to fry with performance.

[mziadd]

I was experiencing very bad performance when I am showing some very basic lines (thickness only to 1), Then after researching I made this modification in the drawing method of the PolyLine layer

Instead of using path.lineTo
Use this :

//Assuming we have the offsets 
final path = ui.Path();
path.addPolygon(polyline.offsets, false); // Here is the magic
canvas.drawPath(path, paint);

polylines.add(CustomPaint(painter: PolylinePainter(polyline, false, false, path: path),size: size,)); 

[ibrierley]

I think that makes sense, and if we were to rewrite it (or write a new plugin for polylines/gons then I'd be tempted to do some caching of the offsets (and likely paths) similar to the recent marker changes.

I'm a little surprised that its so different in performance though for basic lines, or are there a lot of them ?

[mziadd]

i will try to make it as plugin

[ibrierley]

That's great, just shout if you get stuck.

[aitinsan]

i will try to make it as plugin

hi, what about that?