Merged
Conversation
Contributor
Author
|
@johnpryan could you please merge this? |
Collaborator
|
It looks like there's still a few analysis errors: |
* Add new required environment spec Otherwise flutter throws an error and abort building. Fixes fleaflet#774 * Update usage of API for text colors As suggested by joselbr2099 the API have changed in flutter. Replace only colors parameter with textColor. Fixes fleaflet#774
* remove mbtiles and sqlflite dependency * remove mbtiles tile provider + sqflite dependency fixes fleaflet#786 * remove example/test/widget_test
Contributor
Author
|
Hi @johnpryan I pulled in the latest changes and I now only see some warnings concnering Scaffold messenger. |
Collaborator
|
What flutter channel are you using? The Travis check uses stable. I think you need to run |
Contributor
Author
|
Uups, yeah I m on master but I have dartfmt switched to automatic. Will do tomorrow Am 06.01.2021 22:38 schrieb John Ryan <notifications@github.com>:
What flutter channel are you using? The Travis check uses stable.
I think you need to run dartfmt to make the Travis check green.
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.
|
Contributor
Author
|
yep, one file wasn't formated properly |
johnpryan
reviewed
Jan 8, 2021
| ..strokeJoin = StrokeJoin.round | ||
| ..blendMode = BlendMode.dstOut; | ||
| Paint filterPaint; | ||
| if (polylineOpt.borderColor != null) { |
Collaborator
There was a problem hiding this comment.
Is this change intentional?
Contributor
Author
There was a problem hiding this comment.
yeah, that's from an much older commit. I recall that I got null reference exceptions when borderColor wasn't set
Contributor
Author
There was a problem hiding this comment.
Do you see any problem with that?
Collaborator
There was a problem hiding this comment.
No problem, just harder to review :)
| canvas.saveLayer(rect, Paint()); | ||
| if (borderPaint != null) { | ||
| _paintLine(canvas, polylineOpt.offsets, borderPaint); | ||
| if (filterPaint != null) { |
Contributor
Author
There was a problem hiding this comment.
That's the follow up from the above
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new property to be able to disable panning while still keep the View interactive and added a safety check on PolylinePainter