Fixup build errors for the web example#782
Merged
johnpryan merged 2 commits intofleaflet:masterfrom Dec 4, 2020
Merged
Conversation
Otherwise flutter throws an error and abort building. Fixes fleaflet#774
As suggested by joselbr2099 the API have changed in flutter. Replace only colors parameter with textColor. Fixes fleaflet#774
johnpryan
approved these changes
Dec 4, 2020
Collaborator
|
Thanks! |
escamoteur
pushed a commit
to escamoteur/flutter_map
that referenced
this pull request
Jan 6, 2021
* Add new required environment spec Otherwise flutter throws an error and abort building. Fixes fleaflet#774 * Update usage of API for text colors As suggested by joselbr2099 the API have changed in flutter. Replace only colors parameter with textColor. Fixes fleaflet#774
johnpryan
added a commit
that referenced
this pull request
Jan 8, 2021
* patched version * V0.10.2 * fix if PolylineOption.borderColor==null * Fixup build errors for the web example (#782) * Add new required environment spec Otherwise flutter throws an error and abort building. Fixes #774 * Update usage of API for text colors As suggested by joselbr2099 the API have changed in flutter. Replace only colors parameter with textColor. Fixes #774 * remove mbtiles tile provider + sqflite dependency (#787) * remove mbtiles and sqlflite dependency * remove mbtiles tile provider + sqflite dependency fixes #786 * remove example/test/widget_test * updated to latest master version * formatting code Co-authored-by: nickoe <oe.nick@gmail.com> Co-authored-by: John Ryan <ryjohn@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with:
This addresses the concerns raised in #774