Nullsafety by escamoteur · Pull Request #851 · fleaflet/flutter_map

escamoteur · 2021-03-22T16:38:58Z

This is a migration to unsound null safety. So far I couldn't see problems, so I expect as soon as the missing packages are available that should be fine.
At some places I wasn't sure if previous nullable values should still be nullable, I left the null checks despite having changed the types to nonnullables and added a TODO comment.

patched version

johnpryan · 2021-03-22T17:24:35Z

Thanks - will take a look this week

ThexXTURBOXx

I think, these things might need to get changed. Didn't take a very close look at everything, though

ThexXTURBOXx · 2021-03-23T16:09:24Z

  async: ^2.1.0
-  flutter_image: ^3.0.0
-  vector_math: ^2.0.0
+  flutter_image:


I think, the git: part should be declared using a dependency_override

I don't know exactly what the convention is for this repositoy, but I think, it might be better to show that this is a temporary workaround until the changes are uploaded to pub

I see it differently. A dependency_override can easily be missed to be removed when the time comes. Also we don't have to override the dependency of an indirect dependency in this case

I do think it's easier to remove dependency overrides when it's time to use the published version.

ok, I moved it to dependency_override, but as the future version isn't available yet, I set the dependency entry to any

Sata51 · 2021-03-25T14:44:39Z

-    }
    // Interpolate
    var nextZoom = downZoom + 1;
    var nextScale = _scales[nextZoom];


Is there any cases where nextZoom can be out of _scales boundaries ?

Honestly I'm not deep enough into this part to tell. I deleted the three lines above.

Co-authored-by: Sata51 <vm.mathieu@gmail.com>

…tLng>' of 'stream'

Tile layer nullsafety

johnpryan · 2021-04-02T19:34:25Z

It looks like once https://github.com/flutter/flutter_image/pull/22 is published this will be ready

Fix polyline border drawing

…into nullsafety

kengu · 2021-04-08T07:43:11Z

Hi @escamoteur - you need to rebase or merge you branch with current head of master to resolve current conflicts

escamoteur · 2021-04-08T07:47:49Z

Sorry but I think this is a bit the wrong way that we continue to commit to master instead to this PR

kengu · 2021-04-08T07:56:17Z

Sorry but I think this is a bit the wrong way that we continue to commit to master instead to this PR

Do you mean a "code-freeze" on flutter_map master to reduce contention on your branch? I guess that could work for a short-lived branch. In this case however, we are waiting for external dependencies, which could take some time to be resolved (flutter_image is apparently not actively maintained at the moment). And since only you have the permission to push changes to your branch, it effectively blocks the community to maintain flutter_map until this PR is merged.

What do you think @johnpryan?

escamoteur · 2021-04-08T07:58:21Z

Actually I have to inform you that there is a lot work going on on flutter_image. A better alternative would probably by merge my branch into a null-safety branch on this repo so that all can work on it.

kengu · 2021-04-08T08:00:51Z

Actually I have to inform you that there is a lot work going on on flutter_image. A better alternative would probably by merge my branch into a null-safety branch on this repo so that all can work on it.

Yes, that would be better.

escamoteur · 2021-04-08T08:01:24Z

Who can do create a new branch and merge my PR there?

kengu · 2021-04-08T08:05:21Z

Actually I have to inform you that there is a lot work going on on flutter_image.

Good to know. It does not look like that on github or pub.dev though. I left a comment to one of the product manages of Flutter at google asking them if they have time to look at the null-safety PR. Hopefully, he will update us on any plans for this PR

kengu · 2021-04-08T08:07:08Z

Who can do create a new branch and merge my PR there?

I can

escamoteur · 2021-04-08T08:09:34Z

Haven't you seen the comments on the PR from 2 days ago?

kengu · 2021-04-08T08:16:26Z

Haven't you seen the comments on the PR from 2 days ago?

I did, but it wasn't clear from Stuarts commenting (and profile, he is not a listed contributor to flutter_image) if he was in a position to actually decide (all are allowed to add a review) and merge the change. I did get an answer from mit-mit just now, indication that they are monitoring the PR. Hopefully, this means we can expect it to be merged soon.

kengu · 2021-04-08T08:20:30Z

@escamoteur, branch issues-829-nullsafety is created.

escamoteur · 2021-04-08T08:55:17Z

then we can close this PR?

kengu · 2021-04-08T08:57:32Z

then we can close this PR?

Not yet. I haven't merged your branch to it yet. Will do so soon.

escamoteur · 2021-04-14T17:25:17Z

how is the status here?

kengu · 2021-04-14T20:11:49Z

how is the status here?

I'm Sorry @escamoteur , I've been swamped with work lately. The test was failing and had no time to analyse and fix it until now. Your contribution is available in branch issues/829-nullsafety. The new PR is #870. This PR can be closed.

johnpryan and others added 5 commits March 22, 2021 08:49

Add actions/stale@v3 GitHub Action

6f65a0e

patched version

updated to latest master version

508ab2f

updated dependcies to compile again

c89928b

updated latlong import

4119d2e

migrated to unsound null safety

049837a

ThexXTURBOXx suggested changes Mar 23, 2021

View reviewed changes

escamoteur added 2 commits March 23, 2021 17:30

removed .packages from repository

4134956

small fixes

8097851

Sata51 reviewed Mar 25, 2021

View reviewed changes

Comment thread pubspec.yaml Outdated

Sata51 reviewed Mar 25, 2021

View reviewed changes

Comment thread lib/src/core/bounds.dart Outdated

josxha mentioned this pull request Mar 25, 2021

Migrate to null safety #829

Closed

Sata51 suggested changes Mar 25, 2021

View reviewed changes

escamoteur and others added 6 commits March 25, 2021 15:56

Update lib/src/core/point.dart

3e7d6b7

Co-authored-by: Sata51 <vm.mathieu@gmail.com>

Update pubspec.yaml

490f367

Co-authored-by: Sata51 <vm.mathieu@gmail.com>

Update lib/src/gestures/latlng_tween.dart

42ce971

Co-authored-by: Sata51 <vm.mathieu@gmail.com>

type '_ControllerStream<LatLng?>' is not a subtype of type 'Stream<La…

aa64b12

…tLng>' of 'stream'

changes according to review

7439449

Merge pull request #2 from tazik561/tile_layer_nullsafety

24c66ce

Tile layer nullsafety

passsy mentioned this pull request Mar 26, 2021

Replace latlong with latlong2 #854

Merged

escamoteur added 2 commits April 2, 2021 21:25

made key nullable

14c91b1

made rebuild nullable again

3a4ff10

Ahmed-gubara and others added 2 commits April 6, 2021 16:00

Fix polyline border drawing

7736df4

Merge pull request #3 from Ahmed-gubara/patch-1

a4957be

Fix polyline border drawing

kengu mentioned this pull request Apr 7, 2021

update dependency of tuple package from ^1.0.2 to ^2.0.0 #860

Closed

escamoteur added 2 commits April 8, 2021 08:46

corrected typo in dependency_overrides

d946ac1

Merge branch 'nullsafety' of https://github.com/escamoteur/flutter_map …

c7b92f6

…into nullsafety

kengu mentioned this pull request Apr 14, 2021

Upgrade to sound null-safety #870

Merged

kengu closed this Apr 14, 2021

josxha mentioned this pull request May 10, 2021

Replace the flutter_image package with RetryClient from the http package #894

Merged

Uh oh!

Conversation

escamoteur commented Mar 22, 2021

Uh oh!

johnpryan commented Mar 22, 2021

Uh oh!

ThexXTURBOXx left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

johnpryan commented Apr 2, 2021

Uh oh!

kengu commented Apr 8, 2021

Uh oh!

escamoteur commented Apr 8, 2021

Uh oh!

kengu commented Apr 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

escamoteur commented Apr 8, 2021

Uh oh!

kengu commented Apr 8, 2021

Uh oh!

escamoteur commented Apr 8, 2021

Uh oh!

kengu commented Apr 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kengu commented Apr 8, 2021

Uh oh!

escamoteur commented Apr 8, 2021

Uh oh!

kengu commented Apr 8, 2021

Uh oh!

kengu commented Apr 8, 2021

Uh oh!

escamoteur commented Apr 8, 2021

Uh oh!

kengu commented Apr 8, 2021

Uh oh!

escamoteur commented Apr 14, 2021

Uh oh!

kengu commented Apr 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

kengu commented Apr 8, 2021 •

edited

Loading

kengu commented Apr 8, 2021 •

edited

Loading

kengu commented Apr 14, 2021 •

edited

Loading