Upgrade to sound null-safety by kengu · Pull Request #870 · fleaflet/flutter_map

kengu · 2021-04-14T20:10:13Z

Moves @escamoteur nullsafety-branch in PR #851 so that the community can contribute to it without blocking progress.

patched version

Co-authored-by: Sata51 <vm.mathieu@gmail.com>

…tLng>' of 'stream'

johnpryan · 2021-06-01T17:47:04Z

Yes, I can take a look today.

andreandersson · 2021-06-02T07:20:40Z

I've resolved the comments from @ThexXTURBOXx in #919

JaffaKetchup · 2021-06-02T07:24:12Z

Hi,
Glad and excited to see we're almost there!
Can we also merge this as part of this release?
Thanks for the great work you guys have done :)

danielocampo2 · 2021-06-04T11:16:43Z

Thanks for all the work you're doing, is there any update on this review? Eagerly waiting for this and the other flutter_map libs to be updated.

Thanks!

JaffaKetchup · 2021-06-04T14:23:15Z

Hi,
Just to let you guys know, I've made some more changes to the caching section that I added in my PR #913. It might now be quite complicated, however the naming of some tile providers have made it difficult, besides the fact that Flutter's own documentation contradicts itself!
I have also slightly renewed the old offline maps section to let the user know that the guide will be using TileMill which is difficult to install and has some question marks hanging over it's repository.

* Update README.md - Clarified all options for offline mapping - Fixed some capitalisation inconsistencies. * Update README.md

andreandersson · 2021-06-03T12:40:22Z

  List<LayerOptions> group = <LayerOptions>[];

  GroupLayerOptions({
-    Key key,


Just so it isn't missed. GroupLayerOptions should have a nullable constructor. This has been solved in #921.

merged, thanks

…829-nullsafety

…ap into issues/829-nullsafety

Co-authored-by: 6y <tlserver6y@gmail.com>

JaffaKetchup · 2021-06-04T15:01:43Z

Um, my #913 PR was just overwritten. Can we add this back in please? It's quite important I think, because it explains a lot about caching etc...
https://github.com/fleaflet/flutter_map/blob/dadc596e0d7c507ee500f87381872dd7b8bd765a/README.md

…es/829-nullsafety

johnpryan · 2021-06-04T15:05:32Z

@JaffaKetchup There were merge conflicts, so I'm re-adding that manually.

JaffaKetchup · 2021-06-04T15:06:16Z

Ok, I've linked the exact changes I made above (click Raw to copy paste) :)

andreandersson · 2021-06-04T15:07:01Z

Same goes with #919 , not sure if all those have been solved yey

* fix: remove deprecated properties Removes deprecated properties, updates documentation and changed bounds getCenter to a getter. * fix: simplify center getter * docs: improve documentation for NetworkTileProvider * docs: update documentation for tileProvider

…Call updateInterval required.

JaffaKetchup · 2021-06-04T15:41:28Z

Hooray!
Thanks for the work everyone!

aytunch · 2021-06-04T15:45:02Z

Wow :)
I am so happy. When will it be available on pub.dev? And what will be the version number?
Thanks to everyone putting in some great work.

JaffaKetchup · 2021-06-04T15:45:38Z

Yeah same, great if this could be published to pub.dev sooner rather than later.

johnpryan · 2021-06-04T15:48:57Z

Published, thanks everyone!

johnpryan and others added 19 commits April 8, 2021 11:28

Add actions/stale@v3 GitHub Action

911ca0d

patched version

updated to latest master version

dfb91ef

updated dependcies to compile again

49119d1

updated latlong import

f084f2a

migrated to unsound null safety

98ebcff

removed .packages from repository

d210359

small fixes

5633366

Update lib/src/core/point.dart

0bf64bf

Co-authored-by: Sata51 <vm.mathieu@gmail.com>

Update pubspec.yaml

c7d523a

Co-authored-by: Sata51 <vm.mathieu@gmail.com>

Update lib/src/gestures/latlng_tween.dart

48f361e

Co-authored-by: Sata51 <vm.mathieu@gmail.com>

type '_ControllerStream<LatLng?>' is not a subtype of type 'Stream<La…

d1be78e

…tLng>' of 'stream'

changes according to review

f2aaf92

made key nullable

2affa2c

made rebuild nullable again

34bf621

Fix polyline border drawing

cd6ec35

corrected typo in dependency_overrides

53be3ce

Removed unnecessary null-checks

8bb439c

Limit number of purges in TileLayer and cancel pending on dispose

2b509ad

Fix error messages in mocked classes

235dea9

kengu mentioned this pull request Apr 14, 2021

Nullsafety #851

Closed

Set ready to true always (state is never null)

2ff083d

kengu requested a review from johnpryan April 14, 2021 20:23

kengu mentioned this pull request Apr 14, 2021

Migrate to null safety #829

Closed

md-weber mentioned this pull request Apr 19, 2021

Migrate to Null Safety trufi-association/trufi-core#398

Closed

josxha reviewed Apr 21, 2021

View reviewed changes

Comment thread lib/src/map/map.dart Outdated

josxha mentioned this pull request Apr 21, 2021

Null Safety matthiasdittmer/lat_lon_grid_plugin#7

Merged

kengu added 4 commits April 25, 2021 14:05

Merge improved fling physics into sound null-safety branch

0145354

Merge Added new plugin to README

2a71f18

make bounds, getBounds and getCenter null safe

622d7e8

Merge Optimize markers calculations as null safe

daf1dbb

JaffaKetchup mentioned this pull request Jun 4, 2021

Clarification of all options available for offline mapping #913

Merged

johnpryan and others added 2 commits June 4, 2021 07:29

remove TODO

8378acb

Clarification of all options available for offline mapping (#913)

705e32c

* Update README.md - Clarified all options for offline mapping - Fixed some capitalisation inconsistencies. * Update README.md

andreandersson reviewed Jun 4, 2021

View reviewed changes

johnpryan and others added 3 commits June 4, 2021 07:50

Merge branch 'master' of github.com:fleaflet/flutter_map into issues/…

a249d23

…829-nullsafety

Merge branch 'issues/829-nullsafety' of github.com:fleaflet/flutter_m…

618bc12

…ap into issues/829-nullsafety

fix Group Layer Options constructor wrong nullability (#921)

b870970

Co-authored-by: 6y <tlserver6y@gmail.com>

johnpryan added 2 commits June 4, 2021 08:03

null check regex in template()

36154f4

Merge remote-tracking branch 'origin/issues/829-nullsafety' into issu…

863c797

…es/829-nullsafety

johnpryan and others added 6 commits June 4, 2021 08:17

re-apply #913 into null safety branch

9e6dd84

dart format

a86caca

make urlTemplate required, make throttleSTreamTransformerWithTrailing…

40d3a59

…Call updateInterval required.

use late final where possible

3ea0500

revert making urlTemplate non-nullable

2765f26

johnpryan merged commit 368e3b7 into master Jun 4, 2021

JaffaKetchup deleted the issues/829-nullsafety branch June 19, 2022 08:12

Uh oh!

Conversation

kengu commented Apr 14, 2021

Uh oh!

Uh oh!

johnpryan commented Jun 1, 2021

Uh oh!

andreandersson commented Jun 2, 2021

Uh oh!

JaffaKetchup commented Jun 2, 2021

Uh oh!

danielocampo2 commented Jun 4, 2021

Uh oh!

JaffaKetchup commented Jun 4, 2021

Uh oh!

andreandersson Jun 3, 2021

Choose a reason for hiding this comment

Uh oh!

johnpryan Jun 4, 2021

Choose a reason for hiding this comment

Uh oh!

JaffaKetchup commented Jun 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

johnpryan commented Jun 4, 2021

Uh oh!

JaffaKetchup commented Jun 4, 2021

Uh oh!

andreandersson commented Jun 4, 2021

Uh oh!

JaffaKetchup commented Jun 4, 2021

Uh oh!

aytunch commented Jun 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JaffaKetchup commented Jun 4, 2021

Uh oh!

johnpryan commented Jun 4, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

JaffaKetchup commented Jun 4, 2021 •

edited

Loading

aytunch commented Jun 4, 2021 •

edited

Loading