Review comments from issues/829-nullsafety

[andreandersson]

No description provided.

[ThexXTURBOXx]

Thanks for your effort! :)

[JaffaKetchup]

NonCachingNetworkTileProvider() is the default provider, not CachedNetworkTileProvider()! In fact CachedNetworkTileProvider() doesn't actually exist. Honestly, I think the tile providers need a rename! NetworkTileProvider() actually uses NetworkImageWithRetry() which (as far as I understand) doesn't cache tiles, and NonCachingNetworkTileProvider() actually uses NetworkImage() which (as far as I understand) also does cache tiles, but not very well and not very flexibly.

I'd change it to:

/// Provider to load the tiles. The default is `NonCachingNetworkTileProvider()` which
/// doesn't cache tiles and won't retry the HTTP request. Use `NetworkTileProvider()` for
/// a provider which will retry requests. For the best caching implementations, see the
/// flutter_map readme. 

[andreandersson]

NonCachingNetworkTileProvider() is the default provider, not CachedNetworkTileProvider()! In fact CachedNetworkTileProvider() doesn't actually exist. Honestly, I think the tile providers need a rename! NetworkTileProvider() actually uses NetworkImageWithRetry() which (as far as I understand) doesn't cache tiles, and NonCachingNetworkTileProvider() actually uses NetworkImage() which (as far as I understand) also does cache tiles, but not very well and not very flexibly.

I'd change it to:

/// Provider to load the tiles. The default is `NonCachingNetworkTileProvider()` which
/// doesn't cache tiles and won't retry the HTTP request. Use `NetworkTileProvider()` for
/// a provider which will retry requests. For the best caching implementations, see the
/// flutter_map readme. 

Fixed! I believe we should create a ticket for looking further into the documentation around caching and fix it. And I don't think we have to fix it for the null-safety release (which hopefully would happen soon...)

[JaffaKetchup]

Thanks, I think that's a bit better. I'm aiming to clarify the documentation around caching with #913!

Update @andreandersson: I've changed it again! I wish Flutter's docs could agree and whoever decided that the only provider that did cache should be called 'NonCachingNetworkTileProvider()' has made it very confusing for me! Anyways, hopefully I've described everything down to the odd names in the latest commit on my PR.