Skip to content

Rename DeviceSpecificArg to DeviceSpecific#1009

Merged
lockshaw merged 4 commits intoflexflow:repo-refactorfrom
KateUnger:rename_device_specific_arg
Aug 23, 2023
Merged

Rename DeviceSpecificArg to DeviceSpecific#1009
lockshaw merged 4 commits intoflexflow:repo-refactorfrom
KateUnger:rename_device_specific_arg

Conversation

@KateUnger
Copy link
Contributor

@KateUnger KateUnger commented Aug 21, 2023

Description of changes:
Rename DeviceSpecificArg to DeviceSpecific

Related Issues:

Linked Issues:

Issues closed by this PR:


This change is Reviewable

Copy link
Collaborator

@lockshaw lockshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @KateUnger)


lib/runtime/src/ops/aggregate_spec.cc line 162 at r1 (raw file):

  binding.bind_arg(PROFILING, profiling_settings());
  binding.bind_arg(ATTRS, attrs);
  binding.bind_device_specific_arg(

This is still binding an arg, so this should remain bind_device_specific_arg


lib/runtime/src/task_spec/op_task_invocation.h line 57 at r1 (raw file):

  template <typename T>
  void bind_device_specific(slot_id name, OpArgRef<T> const &t) {

Suggestion:

  void bind_device_specific_arg(slot_id name, OpArgRef<T> const &t) {

Copy link
Contributor Author

@KateUnger KateUnger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @lockshaw)


lib/runtime/src/ops/aggregate_spec.cc line 162 at r1 (raw file):

Previously, lockshaw (Colin Unger) wrote…

This is still binding an arg, so this should remain bind_device_specific_arg

Done.


lib/runtime/src/task_spec/op_task_invocation.h line 57 at r1 (raw file):

  template <typename T>
  void bind_device_specific(slot_id name, OpArgRef<T> const &t) {

Done.

Copy link
Collaborator

@lockshaw lockshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @KateUnger)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants