Rename DeviceSpecificArg to DeviceSpecific#1009
Rename DeviceSpecificArg to DeviceSpecific#1009lockshaw merged 4 commits intoflexflow:repo-refactorfrom
Conversation
lockshaw
left a comment
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @KateUnger)
lib/runtime/src/ops/aggregate_spec.cc line 162 at r1 (raw file):
binding.bind_arg(PROFILING, profiling_settings()); binding.bind_arg(ATTRS, attrs); binding.bind_device_specific_arg(
This is still binding an arg, so this should remain bind_device_specific_arg
lib/runtime/src/task_spec/op_task_invocation.h line 57 at r1 (raw file):
template <typename T> void bind_device_specific(slot_id name, OpArgRef<T> const &t) {
Suggestion:
void bind_device_specific_arg(slot_id name, OpArgRef<T> const &t) {
KateUnger
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @lockshaw)
lib/runtime/src/ops/aggregate_spec.cc line 162 at r1 (raw file):
Previously, lockshaw (Colin Unger) wrote…
This is still binding an arg, so this should remain
bind_device_specific_arg
Done.
lib/runtime/src/task_spec/op_task_invocation.h line 57 at r1 (raw file):
template <typename T> void bind_device_specific(slot_id name, OpArgRef<T> const &t) {
Done.
lockshaw
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @KateUnger)
Description of changes:
Rename DeviceSpecificArg to DeviceSpecific
Related Issues:
Linked Issues:
Issues closed by this PR:
This change is