Skip to content

Repo refactor ci #1083

Merged
lockshaw merged 34 commits intoflexflow:repo-refactorfrom
lambda7xx:repo-refactor-ci-lambda
Oct 6, 2023
Merged

Repo refactor ci #1083
lockshaw merged 34 commits intoflexflow:repo-refactorfrom
lambda7xx:repo-refactor-ci-lambda

Conversation

@lambda7xx
Copy link
Contributor

@lambda7xx lambda7xx commented Sep 1, 2023

Description of changes:

  • update the CI and currently we ignore the hip

Related Issues:

Linked Issues:

Issues closed by this PR:

  • Closes #

This change is Reviewable

@lambda7xx lambda7xx requested review from aquan9 and lockshaw September 1, 2023 15:13
@lambda7xx lambda7xx self-assigned this Sep 1, 2023
Copy link
Collaborator

@lockshaw lockshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @aquan9 and @lambda7xx)


run.sh line 0 at r1 (raw file):
Don't know how this file made it in but it should be removed


.github/workflows/gpt-ci.yml-old line 0 at r1 (raw file):
Just remove--we have git history and master


.github/workflows/shell-check.yml line 12 at r1 (raw file):

        uses: ludeeus/action-shellcheck@master
        with:
          shell: bash

Why? (not blocking, just curious)

@lambda7xx
Copy link
Contributor Author

.github/workflows/gpt-ci.yml-old line at r1 (raw file):

Previously, lockshaw (Colin Unger) wrote…

Just remove--we have git history and master

you mean we delete this file?

@lambda7xx lambda7xx requested a review from lockshaw September 26, 2023 13:51
Copy link
Collaborator

@lockshaw lockshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @aquan9)


.github/workflows/gpt-ci.yml-old line at r1 (raw file):

Previously, lambda7xx (Lambda(Xiaoxiang) Shi ) wrote…

you mean we delete this file?

Yes

@lockshaw lockshaw enabled auto-merge (squash) September 26, 2023 14:51
Copy link
Contributor Author

@lambda7xx lambda7xx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 8 of 10 files reviewed, all discussions resolved (waiting on @aquan9 and @lockshaw)


run.sh line at r1 (raw file):

Previously, lockshaw (Colin Unger) wrote…

Don't know how this file made it in but it should be removed

Done.

Copy link
Collaborator

@lockshaw lockshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From slack:

Let's disable "Build FlexFlow with CMake", "Build and Install FlexFlow in a Docker Container", "GPU CI Concierge", "pip-install", "Build FlexFlow with the Makefile", and everything under "gpu-ci" for now
Those currently are expected to fail on repo refactor
So for now only keep "clang-format", "Library CMake Build", and "Shellcheck"

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @aquan9)

Copy link
Contributor Author

@lambda7xx lambda7xx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve

Copy link
Contributor Author

@lambda7xx lambda7xx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aquan9 and @lockshaw)


packaging/docker/flexflow-environment/Dockerfile-old line at r4 (raw file):

Previously, lockshaw (Colin Unger) wrote…

I'm still seeing the file -- I think you forgot to delete Dockerfile-old

Done.

Copy link
Collaborator

@lockshaw lockshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r7, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aquan9 and @lambda7xx)


.github/workflows/per-lib-check.yml line 48 at r7 (raw file):

      - name: Build lib ${{ matrix.library }}
        # run: |

Why did you comment this again? This should be uncommented

Copy link
Collaborator

@lockshaw lockshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r8, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aquan9 and @lambda7xx)

lockshaw
lockshaw previously approved these changes Oct 1, 2023
Copy link
Collaborator

@lockshaw lockshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r9, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aquan9 and @lambda7xx)

@lockshaw lockshaw force-pushed the repo-refactor-ci-lambda branch from fbbb81e to 55f99cc Compare October 6, 2023 05:36
Copy link
Collaborator

@lockshaw lockshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 11 files at r10, 3 of 3 files at r11, 1 of 1 files at r12, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @aquan9)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants