Conversation
lockshaw
left a comment
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @aquan9 and @lambda7xx)
run.sh line 0 at r1 (raw file):
Don't know how this file made it in but it should be removed
.github/workflows/gpt-ci.yml-old line 0 at r1 (raw file):
Just remove--we have git history and master
.github/workflows/shell-check.yml line 12 at r1 (raw file):
uses: ludeeus/action-shellcheck@master with: shell: bash
Why? (not blocking, just curious)
|
Previously, lockshaw (Colin Unger) wrote…
you mean we delete this file? |
lockshaw
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @aquan9)
.github/workflows/gpt-ci.yml-old line at r1 (raw file):
Previously, lambda7xx (Lambda(Xiaoxiang) Shi ) wrote…
you mean we delete this file?
Yes
lambda7xx
left a comment
There was a problem hiding this comment.
Reviewable status: 8 of 10 files reviewed, all discussions resolved (waiting on @aquan9 and @lockshaw)
Previously, lockshaw (Colin Unger) wrote…
Don't know how this file made it in but it should be removed
Done.
lockshaw
left a comment
There was a problem hiding this comment.
From slack:
Let's disable "Build FlexFlow with CMake", "Build and Install FlexFlow in a Docker Container", "GPU CI Concierge", "pip-install", "Build FlexFlow with the Makefile", and everything under "gpu-ci" for now
Those currently are expected to fail on repo refactor
So for now only keep "clang-format", "Library CMake Build", and "Shellcheck"
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @aquan9)
…x/FlexFlow into repo-refactor-ci-lambda
lambda7xx
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aquan9 and @lockshaw)
packaging/docker/flexflow-environment/Dockerfile-old line at r4 (raw file):
Previously, lockshaw (Colin Unger) wrote…
I'm still seeing the file -- I think you forgot to delete
Dockerfile-old
Done.
lockshaw
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r7, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aquan9 and @lambda7xx)
.github/workflows/per-lib-check.yml line 48 at r7 (raw file):
- name: Build lib ${{ matrix.library }} # run: |
Why did you comment this again? This should be uncommented
lockshaw
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r8, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aquan9 and @lambda7xx)
lockshaw
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r9, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aquan9 and @lambda7xx)
fbbb81e to
55f99cc
Compare
lockshaw
left a comment
There was a problem hiding this comment.
Reviewed 10 of 11 files at r10, 3 of 3 files at r11, 1 of 1 files at r12, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @aquan9)
Description of changes:
Related Issues:
Linked Issues:
Issues closed by this PR:
This change is