Skip to content

Replicate OP #1101

Merged
reyna-abhyankar merged 14 commits intoflexflow:repo-refactorfrom
lambda7xx:repo-refactor-lambda-replicate-OP
Oct 19, 2023
Merged

Replicate OP #1101
reyna-abhyankar merged 14 commits intoflexflow:repo-refactorfrom
lambda7xx:repo-refactor-lambda-replicate-OP

Conversation

@lambda7xx
Copy link
Contributor

@lambda7xx lambda7xx commented Sep 6, 2023

Description of changes:

  • update the reshape operator

Related Issues:

Linked Issues:

Issues closed by this PR:

  • Closes #

This change is Reviewable

@lambda7xx lambda7xx requested review from lockshaw and removed request for lockshaw September 24, 2023 19:41
Copy link
Collaborator

@wmdi wmdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @KateUnger, @lambda7xx, @lockshaw, and @reyna-abhyankar)


lib/runtime/src/ops/replicate.cc line 45 at r2 (raw file):

using namespace FlexFlow::Kernels::Replicate;

enum Slots { INPUT, OUTPUT, ATTRS, PROFILING };

I don't see any reference of ATTRS

@lambda7xx
Copy link
Contributor Author

lib/runtime/src/ops/replicate.cc line 45 at r2 (raw file):

Previously, wmdi (Mengdi Wu) wrote…

I don't see any reference of ATTRS

remove the init because it doesn't need perdevicestate.

@reyna-abhyankar
Copy link
Collaborator

Reviewed 2 of 3 files at r1.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @KateUnger, @lambda7xx, @lockshaw, and @reyna-abhyankar)

lib/runtime/src/ops/replicate.cc line 45 at r2 (raw file):

using namespace FlexFlow::Kernels::Replicate;

enum Slots { INPUT, OUTPUT, ATTRS, PROFILING };

I don't see any reference of ATTRS

ReshapeAttrs has one field: TensorShape shape. If this is necessary to call the kernel, then we should bind to ATTRS.

@lambda7xx lambda7xx requested a review from lockshaw October 12, 2023 23:11
@reyna-abhyankar reyna-abhyankar requested a review from wmdi October 17, 2023 17:06
Copy link
Collaborator

@wmdi wmdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r4, 1 of 1 files at r6, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @lockshaw)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants