Reduction OP

[lambda7xx]

Description of changes:

• upate the Reduction OP

Related Issues:

Linked Issues:

• Issue Update Reduction operator #1075

Issues closed by this PR:

• Closes Update Reduction operator #1075

---

This change is 

[wmdi]

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @lambda7xx, @lockshaw, and @reyna-abhyankar)

---

lib/runtime/src/ops/reduction.cc line 19 at r1 (raw file):

#include "kernels/reduction_kernels.h"
#include "op-attrs/get_output_shape.h"
#include "utils/exception.decl.h"

decl.h files should not be included here.

[wmdi]

Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @lambda7xx, @lockshaw, and @reyna-abhyankar)

---

lib/runtime/src/ops/reduction.cc line 19 at r1 (raw file):

Previously, wmdi (Mengdi Wu) wrote…

decl.h files should not be included here.

I also noticed a few other files outside utils including.decl.h. Remember to update them as well.

[lambda7xx]

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @lockshaw, @reyna-abhyankar, and @wmdi)

---

lib/runtime/src/ops/reduction.cc line 19 at r1 (raw file):

Previously, wmdi (Mengdi Wu) wrote…

I also noticed a few other files outside utils including.decl.h. Remember to update them as well.

Done.

[lambda7xx]

lib/runtime/src/ops/reduction.cc line 19 at r1 (raw file):

Previously, lambda7xx (Lambda(Xiaoxiang) Shi ) wrote…

Done.

currently, other files like contaners.h use .decl.h is not my side. I will check my other pr

[lambda7xx]

Reviewable status: 2 of 3 files reviewed, 3 unresolved discussions (waiting on @lockshaw, @reyna-abhyankar, and @wmdi)

---

lib/runtime/src/ops/reduction.cc line 79 at r2 (raw file):

Previously, reyna-abhyankar (Reyna Abhyankar) wrote…

bump @lockshaw

Done.

---

lib/runtime/src/ops/reduction.cc line 149 at r2 (raw file):

Previously, reyna-abhyankar (Reyna Abhyankar) wrote…

bump @lambda7xx

Done.

[wmdi]

Reviewed all commit messages.
Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @lambda7xx, @lockshaw, and @reyna-abhyankar)

[wmdi]

Reviewed 1 of 1 files at r4.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @lockshaw and @reyna-abhyankar)

[lambda7xx]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @reyna-abhyankar)

---

lib/runtime/src/ops/reduction.cc line 79 at r2 (raw file):

Previously, lockshaw (Colin Unger) wrote…

Yeah I agree @reyna-abhyankar

Done.