Conversation
lockshaw
left a comment
There was a problem hiding this comment.
Reviewed 41 of 41 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lambda7xx, @reyna-abhyankar, and @wmdi)
lib/runtime/src/task_spec.cc line 109 at r1 (raw file):
} // TODO: deprecate
Why? (add a link in the code to a github issue with explanation)
reyna-abhyankar
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lambda7xx, @lockshaw, and @wmdi)
lib/runtime/src/task_spec.cc line 109 at r1 (raw file):
Previously, lockshaw (Colin Unger) wrote…
Why? (add a link in the code to a github issue with explanation)
I've changed get_signature in the op task PR. We can actually just delete this code
lockshaw
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @lambda7xx and @wmdi)
Description of changes:
In some places, it is commented out because aggregate was used as an example for implementation of something that has not been completed. I've left it as an example and it should be removed once completed
Related Issues:
Linked Issues:
Issues closed by this PR:
Aggregate,AggregateSpec,GroupBy) #1127This change is