Skip to content

Purge MOE operators#1177

Merged
lockshaw merged 8 commits intoflexflow:repo-refactorfrom
reyna-abhyankar:purge-moe
Oct 12, 2023
Merged

Purge MOE operators#1177
lockshaw merged 8 commits intoflexflow:repo-refactorfrom
reyna-abhyankar:purge-moe

Conversation

@reyna-abhyankar
Copy link
Collaborator

@reyna-abhyankar reyna-abhyankar commented Oct 7, 2023

Description of changes:

In some places, it is commented out because aggregate was used as an example for implementation of something that has not been completed. I've left it as an example and it should be removed once completed

Related Issues:

Linked Issues:

  • Issue #

Issues closed by this PR:


This change is Reviewable

Copy link
Collaborator

@lockshaw lockshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 41 of 41 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lambda7xx, @reyna-abhyankar, and @wmdi)


lib/runtime/src/task_spec.cc line 109 at r1 (raw file):

}

// TODO: deprecate

Why? (add a link in the code to a github issue with explanation)

Copy link
Collaborator Author

@reyna-abhyankar reyna-abhyankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lambda7xx, @lockshaw, and @wmdi)


lib/runtime/src/task_spec.cc line 109 at r1 (raw file):

Previously, lockshaw (Colin Unger) wrote…

Why? (add a link in the code to a github issue with explanation)

I've changed get_signature in the op task PR. We can actually just delete this code

Copy link
Collaborator

@lockshaw lockshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @lambda7xx and @wmdi)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Purge MoE operators (Aggregate, AggregateSpec, GroupBy)

2 participants