linear operator

[lambda7xx]

Description of changes:

• update the linear operator
• init_kernel has some problem, we need to fix it.

Related Issues:

Linked Issues:

• Issue Update Linear operator #1071

Issues closed by this PR:

• Closes #

---

This change is 

[lambda7xx]

lib/runtime/src/ops/linear.cc line 86 at r1 (raw file):

Previously, reyna-abhyankar (Reyna Abhyankar) wrote…

We had agreed previously that ff_dim_t{1} is batch size. Is this equivalent?

ok, make sense

[lambda7xx]

lib/runtime/src/ops/linear.cc line 92 at r1 (raw file):

Previously, reyna-abhyankar (Reyna Abhyankar) wrote…

I don't think this function call matches what you have in the kernel.

where? maybe this. should be

Code snippet:

  DeviceSpecific<LinearPerDeviceState> state =
      acc.create_device_specific<LinearPerDeviceState>(
          init_kernel(handle,
                      allocator,
                      one_ptr,
                      attrs.regularizer,
                      attrs.use_bias,
                      input.data_type,
                      weight.data_type,
                      output.data_type,
                      batch_size,
                      attrs.out_channels));
  return state;
}

[lambda7xx]

Reviewable status: 0 of 6 files reviewed, 12 unresolved discussions (waiting on @reyna-abhyankar)

---

lib/kernels/src/cuda/linear_kernels.cu line 28 at r1 (raw file):

Previously, reyna-abhyankar (Reyna Abhyankar) wrote…

What is Activation I think this should be ActiMode

Done.

---

lib/kernels/src/cuda/linear_kernels.cu line 71 at r1 (raw file):

Previously, reyna-abhyankar (Reyna Abhyankar) wrote…

Use the same allocation method that is in the original constructor for LinearPerDeviceState

Done.

---

lib/runtime/src/ops/element_binary.cc line 216 at r1 (raw file):

Previously, reyna-abhyankar (Reyna Abhyankar) wrote…

Don't worry about it in this PR. If it's a problem, you can open an issue

Done.

---

lib/runtime/src/ops/linear.cc line 37 at r1 (raw file):

Previously, reyna-abhyankar (Reyna Abhyankar) wrote…

  ATTRS,

Done.

---

lib/runtime/src/ops/linear.cc line 40 at r1 (raw file):

Previously, reyna-abhyankar (Reyna Abhyankar) wrote…

Why?

Done.

---

lib/runtime/src/ops/linear.cc line 46 at r1 (raw file):

Previously, reyna-abhyankar (Reyna Abhyankar) wrote…

  bind.bind_arg(ATTRS, attrs);

Done.

---

lib/runtime/src/ops/linear.cc line 85 at r1 (raw file):

Previously, reyna-abhyankar (Reyna Abhyankar) wrote…

Why the + 1?

Done.

---

lib/runtime/src/ops/linear.cc line 202 at r1 (raw file):

Previously, reyna-abhyankar (Reyna Abhyankar) wrote…

I think these should always be InputParallelTensorDesc instead of ParallelTensorShape

Done.

---

deps/fmt line 0 at r1 (raw file):

Previously, reyna-abhyankar (Reyna Abhyankar) wrote…

Use most updated submodules

Done.