Resurrect substitution-to-dot#1351
Merged
lockshaw merged 3 commits intoflexflow:repo-refactorfrom May 23, 2024
Merged
Conversation
wmdi
approved these changes
May 23, 2024
Collaborator
wmdi
left a comment
wmdi
left a comment
There was a problem hiding this comment.
Reviewed 20 of 20 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @lockshaw)
wmdi
approved these changes
May 23, 2024
Collaborator
wmdi
left a comment
wmdi
left a comment
There was a problem hiding this comment.
Reviewable status:
wmdi
approved these changes
May 23, 2024
Collaborator
wmdi
left a comment
wmdi
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
This was referenced Jan 15, 2025
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Port
substitution-to-dotover frommastertorepo-refactor, divide intolib/substitution-generatorandbin/substitution-to-dot, and port over tests (added to CI).Also had to improve some of the fmting code due to encountering some errors. Delegating
operator<<to thefmtimplementation is now opt-in rather than opt-out for arbitrary types, though it is on by default for any visitable orstrong_typedeftypes.Related Issues:
Linked Issues:
Issues closed by this PR:
This change is