Skip to content

Hip Refactor for optimizer, partition and pool#1379

Merged
reyna-abhyankar merged 6 commits intoflexflow:repo-refactorfrom
Bob-Chen222:bob-hip-refactor-mnop
May 31, 2024
Merged

Hip Refactor for optimizer, partition and pool#1379
reyna-abhyankar merged 6 commits intoflexflow:repo-refactorfrom
Bob-Chen222:bob-hip-refactor-mnop

Conversation

@Bob-Chen222
Copy link
Contributor

@Bob-Chen222 Bob-Chen222 commented Apr 21, 2024

Description of changes:

add optimizer, partition, pool hip refactor

Related Issues:

Linked Issues:

Issues closed by this PR:

  • Closes #

This change is Reviewable

Copy link
Collaborator

@reyna-abhyankar reyna-abhyankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments

Copy link
Contributor Author

@Bob-Chen222 Bob-Chen222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done:)

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @reyna-abhyankar)


lib/kernels/src/hip/pool_2d_kernels.cpp line 59 at r1 (raw file):

Previously, reyna-abhyankar (Reyna Abhyankar) wrote…

Why?

I see. I changed INCLUDE to EXCLUDE in the macro. Thanks for pointing out.

Copy link
Collaborator

@reyna-abhyankar reyna-abhyankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @Bob-Chen222)


lib/kernels/src/hip/pool_2d_kernels.cpp line 59 at r1 (raw file):

Previously, Bob-Chen222 (Bob Chen) wrote…

I see. I changed INCLUDE to EXCLUDE in the macro. Thanks for pointing out.

What do you mean? Isn't the API itself supposed to be miopenPoolingAverage?

Copy link
Contributor Author

@Bob-Chen222 Bob-Chen222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @reyna-abhyankar)


lib/kernels/src/hip/pool_2d_kernels.cpp line 59 at r1 (raw file):

Previously, reyna-abhyankar (Reyna Abhyankar) wrote…

What do you mean? Isn't the API itself supposed to be miopenPoolingAverage?

Got it. It has now reverted to the previous version. I trusted GPT too much...


lib/kernels/src/hip/optimizer_kernel.cpp line 0 at r1 (raw file):

Previously, reyna-abhyankar (Reyna Abhyankar) wrote…

Don't worry about the optimizer kernels. We haven't properly refactored the cuda file

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants