Code Coverage Support#1396
Conversation
This reverts commit b33647a.
lockshaw
left a comment
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Bob-Chen222)
.github/workflows/helpers/cmake_cuda.sh line 28 at r1 (raw file):
-DCMAKE_CXX_COMPILER_LAUNCHER=ccache \ -DCMAKE_CUDA_COMPILER_LAUNCHER=ccache \ "${FLAGS[@]}"
Suggestion:
../config/config.linux \
-DCMAKE_C_COMPILER_LAUNCHER=ccache \
-DCMAKE_CXX_COMPILER_LAUNCHER=ccache \
-DCMAKE_CUDA_COMPILER_LAUNCHER=ccache \
-DFF_USE_CODE_COVERAGE=ON \
"${FLAGS[@]}"
Bob-Chen222
left a comment
There was a problem hiding this comment.
Reviewable status: 6 of 7 files reviewed, 1 unresolved discussion (waiting on @lockshaw)
.github/workflows/helpers/cmake_cuda.sh line 28 at r1 (raw file):
-DCMAKE_CXX_COMPILER_LAUNCHER=ccache \ -DCMAKE_CUDA_COMPILER_LAUNCHER=ccache \ "${FLAGS[@]}"
Done.
lockshaw
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Bob-Chen222)
lockshaw
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Bob-Chen222)
lockshaw
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Bob-Chen222)
.github/workflows/per-lib-check.yml line 115 at r4 (raw file):
verbose: true - name: Test substitution-generator
You probably want to run all tests before uploading the codecov info?
lockshaw
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Bob-Chen222)
Description of changes:
proj cmakewill create two separate build folders. build and build_codecov. Additional flag FF_USE_CODE_COVERAGE is added to achieve the optional instrumentation in cmakeproj test --coveragewill generate coverage info in terminal.proj test --coverage --browserwill run the report in user's browser(if have one)Related Issues:
Linked Issues:
Issues closed by this PR:
This change is