Run proj dtgen in CI#1424
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## repo-refactor #1424 +/- ##
==============================================
Coverage 39.28% 39.28%
==============================================
Files 253 253
Lines 8859 8859
Branches 324 324
==============================================
Hits 3480 3480
Misses 5379 5379
Flags with carried forward coverage won't be shown. Click here to find out more. |
reyna-abhyankar
left a comment
There was a problem hiding this comment.
Reviewed 282 of 282 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Bob-Chen222 and @lockshaw)
flake.nix line 104 at r1 (raw file):
lcov # for code coverage ]) (with proj-repo.packages.${system}; [
What does moving this here do?
.github/workflows/per-lib-check.yml line 57 at r1 (raw file):
- name: Regenerate all dtgen files run: | proj dtgen --force --delete-outdated
So when pulling in changes, we should run this command?
lockshaw
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Bob-Chen222 and @reyna-abhyankar)
flake.nix line 104 at r1 (raw file):
Previously, reyna-abhyankar (Reyna Abhyankar) wrote…
What does moving this here do?
Makes proj available in CI (shouldn't develop experience at all, as the default shell inherits dependencies from the ci shell)
.github/workflows/per-lib-check.yml line 57 at r1 (raw file):
Previously, reyna-abhyankar (Reyna Abhyankar) wrote…
So when pulling in changes, we should run this command?
No, it (minus the force parameter) gets auto-run by proj build, proj test, etc. (I think also proj cmake). You shouldn't have to do anything differently on your side, this only affects CI
reyna-abhyankar
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @Bob-Chen222)
Description of changes:
Run
proj dtgenin CI so that.dtg.hand.dtg.ccfiles don't need to be committed into the repoRelated Issues:
Linked Issues:
Issues closed by this PR:
This change is