Skip to content

Fix concretize_abstract_tensor_set_movement#1519

Merged
lockshaw merged 2 commits intoflexflow:repo-refactorfrom
lockshaw:concretize-abstract-tensor-set-movement-fix
Oct 8, 2024
Merged

Fix concretize_abstract_tensor_set_movement#1519
lockshaw merged 2 commits intoflexflow:repo-refactorfrom
lockshaw:concretize-abstract-tensor-set-movement-fix

Conversation

@lockshaw
Copy link
Collaborator

@lockshaw lockshaw commented Oct 8, 2024

Description of changes:

Related Issues:

Linked Issues:

  • Issue #

Issues closed by this PR:

  • Closes #

This change is Reviewable

@codecov
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 99.19355% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.10%. Comparing base (b77598c) to head (d401426).
Report is 1 commits behind head on repo-refactor.

Files with missing lines Patch % Lines
...ne_mapping/get_tensor_set_movement_across_split.cc 99.19% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           repo-refactor    #1519      +/-   ##
=================================================
+ Coverage          75.95%   76.10%   +0.15%     
=================================================
  Files                777      778       +1     
  Lines              25487    25611     +124     
  Branches             720      720              
=================================================
+ Hits               19359    19492     +133     
+ Misses              6128     6119       -9     
Flag Coverage Δ
unittests 76.10% <99.19%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ne_mapping/get_tensor_set_movement_across_split.cc 99.19% <99.19%> (ø)

... and 3 files with indirect coverage changes

@lockshaw lockshaw merged commit a9d10d7 into flexflow:repo-refactor Oct 8, 2024
@lockshaw lockshaw deleted the concretize-abstract-tensor-set-movement-fix branch October 8, 2024 05:52
@victorli2002 victorli2002 mentioned this pull request Mar 12, 2025
@victorli2002 victorli2002 mentioned this pull request Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant