Conversation
lockshaw
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Marsella8)
lib/utils/src/utils/containers/recurse_n.cc line 1 at r1 (raw file):
#include "utils/containers/recurse_n.h"
Can you add a value_type specialization to force it to typecheck? (example: https://github.com/flexflow/FlexFlow/blob/89c143d33b9e02faf8d6818a9c47b0d5da68a610/lib/utils/src/utils/containers/get_all_assignments.cc)
Marsella8
left a comment
There was a problem hiding this comment.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @lockshaw)
lib/utils/src/utils/containers/recurse_n.cc line 1 at r1 (raw file):
Previously, lockshaw (Colin Unger) wrote…
Can you add a
value_typespecialization to force it to typecheck? (example: https://github.com/flexflow/FlexFlow/blob/89c143d33b9e02faf8d6818a9c47b0d5da68a610/lib/utils/src/utils/containers/get_all_assignments.cc)
The things we have to do to mimick generics...
Let me know if this is what you were thinking (I've verified that it does actually complain at compile time)
lockshaw
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Marsella8)
Description of changes:
added recurse_n function in containers library
Related Issues:
Linked Issues:
Issues closed by this PR:
Before merging:
This change is