Fix cuda_fp16.h not found issue#834
Merged
lockshaw merged 1 commit intoflexflow:repo-refactorfrom Jul 6, 2023
Merged
Conversation
96674dc to
068e157
Compare
Contributor
|
@lockshaw Should this PR also fix the build error? |
KateUnger
approved these changes
Jul 6, 2023
This was referenced Jan 15, 2025
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
On machines where the cuda headers were not automatically being searched, a build error would result in
utils/fp16.h. This fixes that by explicitly adding the found cuda include directories to the requirements ofutils.Related Issues:
Linked Issues:
Issues closed by this PR:
Before merging: