refactor(alluxio): remove redundant CacheStates update from UpdateDat…

[lin121291]

Ⅰ. Describe what this PR does

Remove redundant CacheStates assignment and unnecessary getRuntime()
call from AlluxioEngine.UpdateDatasetStatus().

UpdateDatasetStatus() manages dataset phase and conditions. It also
sets CacheStates, duplicating the work of UpdateCacheOfDataset()
which is the authoritative source (called at Sync step 5 in
pkg/ddc/base/syncs.go:79).

The assignment is a no-op in all code paths:

• Setup (BindToDataset): Runtime just created, CacheStates is empty
• Sync healthy path: step 5 UpdateCacheOfDataset() overwrites immediately after
• Sync unhealthy path: step 4 CheckAndUpdateRuntimeStatus never ran,
  so runtime.Status.CacheStates already equals dataset.Status.CacheStates
  from last successful sync

The existing TODO comment in the code confirms this was a known concern.

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. List the added test cases

No new tests needed. The removed code was a no-op — existing tests for
UpdateDatasetStatus() and UpdateCacheOfDataset() continue to pass.

Ⅳ. Describe how to verify it

FLUID_UNIT_TEST=true go test ./pkg/ddc/alluxio/... -count=1

notes

• e.runtime (engine struct field, used for Spec.Master.Replicas) is NOT affected — only the local runtime variable from getRuntime() is removed
• All other runtime engines have the same pattern ; will submit a follow-up PR after this one is merged

[fluid-e2e-bot]

Hi @lin121291. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[gemini-code-assist]

Code Review

This pull request simplifies the UpdateDatasetStatus function in the Alluxio engine by removing the retrieval of runtime status and the redundant update of CacheStates. These changes streamline the status update process, as CacheStates are managed in a separate function. I have no feedback to provide as no review comments were present.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.17%. Comparing base (82e490e) to head (0da0235).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5806      +/-   ##
==========================================
- Coverage   58.17%   58.17%   -0.01%     
==========================================
  Files         478      478              
  Lines       32485    32477       -8     
==========================================
- Hits        18899    18894       -5     
+ Misses      12042    12040       -2     
+ Partials     1544     1543       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

This PR refactors the Alluxio runtime’s dataset status update flow by removing a redundant CacheStates write and an unnecessary getRuntime() fetch from AlluxioEngine.UpdateDatasetStatus(), keeping cache state updates centralized in UpdateCacheOfDataset() (called from the base sync flow).

Changes:

• Removed getRuntime() call from AlluxioEngine.UpdateDatasetStatus().
• Removed redundant assignment of dataset.Status.CacheStates inside UpdateDatasetStatus() (avoids duplicating UpdateCacheOfDataset() behavior).
• Dropped the related TODO/commented-out lines that indicated the duplication.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[cheyang]

The change is correct. The CacheStates assignment in UpdateDatasetStatus() is indeed a no-op across all call paths:

• BindToDataset: Runtime just created, runtime.Status.CacheStates is empty
• Sync healthy path: CheckAndUpdateRuntimeStatus() (step 4) populates runtime cache states, then UpdateCacheOfDataset() (step 5) overwrites dataset cache states immediately after CheckRuntimeHealthy() calls UpdateDatasetStatus()
• Sync unhealthy path: CheckRuntimeHealthy() returns early before CheckAndUpdateRuntimeStatus(), so runtime.Status.CacheStates is stale and identical to what's already on the dataset from the last successful sync

Removing the redundant getRuntime() call also saves an unnecessary API server read on every status update.

Verified against the sync flow in pkg/ddc/base/syncs.go and all callers in health_check.go and replicas.go. No race conditions or behavioral regressions found.

LGTM.

[cheyang]

/lgtm
/approve

[fluid-e2e-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [cheyang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment