Skip to content

refactor(alluxio): remove redundant CacheStates update from UpdateDat… #5806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fluid-e2e-bot merged 1 commit into from
Apr 27, 2026
+0 −11
Merged

refactor(alluxio): remove redundant CacheStates update from UpdateDat… #5806

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions pkg/ddc/alluxio/dataset.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,13 +75,6 @@ func (e *AlluxioEngine) UpdateCacheOfDataset() (err error) {

// UpdateDatasetStatus updates the status of the dataset
func (e *AlluxioEngine) UpdateDatasetStatus(phase datav1alpha1.DatasetPhase) (err error) {
// 1. update the runtime status
runtime, err := e.getRuntime()
if err != nil {
return err
}

// 2.update the dataset status
err = retry.RetryOnConflict(retry.DefaultBackoff, func() error {
dataset, err := utils.GetDataset(e.Client, e.name, e.namespace)
if err != nil {
Expand Down Expand Up @@ -127,10 +120,6 @@ func (e *AlluxioEngine) UpdateDatasetStatus(phase datav1alpha1.DatasetPhase) (er
cond)
}

// TODO: Do we have to update cachestates here? It is updated in AlluxioEngine.UpdateCacheOfDataset()
datasetToUpdate.Status.CacheStates = runtime.Status.CacheStates
// datasetToUpdate.Status.CacheStates =

if datasetToUpdate.Status.HCFSStatus == nil {
datasetToUpdate.Status.HCFSStatus, err = e.GetHCFSStatus()
if err != nil {
Expand Down
Loading