-
Notifications
You must be signed in to change notification settings - Fork 52
Refactor, run clean command after each test, improve logic for setting default targets. #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Don't catch exceptions. - Fix incorrectly used nested f-string.
bbrto21
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
I can't test with wearable device not emulator. |
|
@bbrto21 |
Actually, I've set the default target as wearable-5.5 for now and since wearable-5.5.0.2 is technically not the exact version, the error message I've seen offline on your machine is correct. I thought about improving this, but left it as a TODO. plugins/tools/commands/integration_test.py Lines 100 to 102 in 0ca3a10
Since the issue came up, I'll find a better way to set default targets. |
- Update outdated docstring. - Add target definition in docstring. - Update variable names based on definition.
By default, the tools selects all connected targets for testing. - Add `--platforms` option to specify group of testing targets.
|
@bbrto21 |
|
@HakkyuKim |
Sorry for the unexpected huge diff, adding default targets was not as straightforward as I originally thought. I may have done some over refactoring but I already had planned the changes for #230. It was simpler to work with the refactored code so I decided to apply it a bit early.
This PR must be merged after adding the
--platformsoption inintegration_test.yml.Summary:
(Nothing has changed between line 136~237)Targetwhich encapsulates a Tizen device.TargetManagerwhich finds and manages a collection ofTargets.target,platform, etc.--platformsoption which takes inputs of the form<device_profile>-<tizen_version>, the tool will find all satisfying targets and serve them as test devices.