Ephemeral targets(emulators) #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improve/update/add/move documentation. - Remove legacy class member of `TargetManager`, `target_per_id`. - Raise exception in `EphemeralTarget.create()` on failure. - Add trailing commas in some parameter lists for readability. - Rename `TargetManager.platforms()` to `TargetManager.get_platforms()`. - Call `super().__init__()` first in `EphemeralTargetManager.__init__()`. - Call `super().__exit__()` in `EphemeralTargetManager.__exit__()`.
Also: - Exit tool if --use-ephemeral-targets option is not used with --platforms. - Include Tizen version in created ephemeral target name.
Also: - Use valid characters for target name.
Also - Group imports from same module.
--use-ephermeral-targets. Also: - Make --platforms and --recipe options mutually exclusive.
WonyoungChoi
reviewed
Oct 5, 2021
WonyoungChoi
reviewed
Oct 5, 2021
Also: - Use kill command for powering off targets for all device profiles.
Contributor
Author
|
@WonyoungChoi |
bwikbs
approved these changes
Oct 5, 2021
Member
bwikbs
left a comment
bwikbs
left a comment
There was a problem hiding this comment.
It's going a lot faster than I imagined. AWESOME!!! 💯
bwikbs
pushed a commit
to bwikbs/plugins
that referenced
this pull request
Mar 26, 2022
* Use TargetManager with "with" statement * Implement ephmeral target features * Clean ups - Improve/update/add/move documentation. - Remove legacy class member of `TargetManager`, `target_per_id`. - Raise exception in `EphemeralTarget.create()` on failure. - Add trailing commas in some parameter lists for readability. - Rename `TargetManager.platforms()` to `TargetManager.get_platforms()`. - Call `super().__init__()` first in `EphemeralTargetManager.__init__()`. - Call `super().__exit__()` in `EphemeralTargetManager.__exit__()`. * Validate --platforms option Also: - Exit tool if --use-ephemeral-targets option is not used with --platforms. - Include Tizen version in created ephemeral target name. * Support tv profile Also: - Use valid characters for target name. * Remove if statement in choosing subcommands Also - Group imports from same module. * Document dependent executables info * Allow either --platforms or --recipe with --use-ephermeral-targets. Also: - Make --platforms and --recipe options mutually exclusive. * Update based on review * Store pid in launch and use it in poweroff Also: - Use kill command for powering off targets for all device profiles. * Remove unnecessry cwd argument in some places
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows creating and deleting emulators during tests. The feature is required to run multiple self-hosted runners on a single machine.
Contributes to #230.
Depends on #229, will rebase after #229 is merged. (done)
Run the following command to test:
Miscs:
--platformsand--recipeoptions mutually exclusive, this got left out in Refactor, run clean command after each test, improve logic for setting default targets. #229 by mistake.Limitation: