Skip to content

Conversation

@HakkyuKim
Copy link
Contributor

@HakkyuKim HakkyuKim commented Oct 5, 2021

Summary:

  • Resolve warnings from dart analyze for package_info_plus, share_plus, wearable_rotary, and message_port.
  • Resolve warnings from flutter analyze in 2.5.1 for path_provider, permission_handler, and url_launcher.

Partially contributes to #223.

@HakkyuKim
Copy link
Contributor Author

@bbrto21
Do you know anything about this warning?
It complains when I run dart analyze in share_plus but not in package_info_plus.

warning • analysis_options.yaml:1:10 • The include file
          'package:pedantic/analysis_options.yaml' in
          '/home/hakkyu/mydir/project/flutter_tizen_dev/plugins/analysis_options_plus.yaml'
          can't be found when analyzing
          '/home/hakkyu/mydir/project/flutter_tizen_dev/plugins/packages/share_plus'.
          • include_file_not_found

@HakkyuKim
Copy link
Contributor Author

HakkyuKim commented Oct 5, 2021

The integration test is failing for package_info_plus because the screen of the emulator target running on the internal CI server is off. It does that sometimes after a few days even when I set the screen display to be "always on". This problem will be solved after applying --use-ephemeral-targets in #232.

@bbrto21
Copy link
Contributor

bbrto21 commented Oct 6, 2021

@bbrto21 Do you know anything about this warning? It complains when I run dart analyze in share_plus but not in package_info_plus.

warning • analysis_options.yaml:1:10 • The include file
          'package:pedantic/analysis_options.yaml' in
          '/home/hakkyu/mydir/project/flutter_tizen_dev/plugins/analysis_options_plus.yaml'
          can't be found when analyzing
          '/home/hakkyu/mydir/project/flutter_tizen_dev/plugins/packages/share_plus'.
          • include_file_not_found

@HakkyuKim
Some analysis option have dependencies on other plugins, you need to run flutter-tizen pub get before analyze

@HakkyuKim
Copy link
Contributor Author

The integration test is failing for package_info_plus because the screen of the emulator target running on the internal CI server is off. It does that sometimes after a few days even when I set the screen display to be "always on". This problem will be solved after applying --use-ephemeral-targets in #232.

Hmm...the same problem occurs even after restarting the emulator. This is unexpected, I would have to check when I'm back in office.

@HakkyuKim
Copy link
Contributor Author

@HakkyuKim Some analysis option have dependencies on other plugins, you need to run flutter-tizen pub get before analyze

@bbrto21
Not sure why but I couldn't run flutter-tizen pub get in share_plus due to formatting error in pubspec.lock, flutter-tizen pub get works after erasing the file and no warnings are shown for dart analyze. Thanks for the help.

@HakkyuKim HakkyuKim marked this pull request as ready for review October 6, 2021 02:12
@HakkyuKim
Copy link
Contributor Author

Hmm...the same problem occurs even after restarting the emulator. This is unexpected, I would have to check when I'm back in office.

It was the screen problem which I knew about.

@HakkyuKim HakkyuKim requested a review from bwikbs October 8, 2021 00:09
Copy link
Member

@bwikbs bwikbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me that it works well! Thank you! 👍

@HakkyuKim HakkyuKim merged commit 8a1d464 into flutter-tizen:master Oct 8, 2021
@HakkyuKim HakkyuKim mentioned this pull request Oct 19, 2021
59 tasks
@HakkyuKim HakkyuKim deleted the resolve-analyze-warnings branch December 21, 2021 04:34
bwikbs pushed a commit to bwikbs/plugins that referenced this pull request Mar 26, 2022
* Resolve some linter warnings

* Change back to pickImage after pub upgrade

* Update based on review

* Use clear comments

* Resolve flutter analyze warnings in 2.5.1

* Ignore impl doc warnings for url_launcher
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants