Skip to content
This repository was archived by the owner on Apr 21, 2025. It is now read-only.

Conversation

@blasten
Copy link

@blasten blasten commented Jul 21, 2021

Required for flutter/engine#27413

@blasten blasten requested review from GaryQian and dnfield July 21, 2021 22:07
default_android_sdk_version = "30"
default_android_sdk_build_tools_version = "30.0.2"
default_android_sdk_version = "31"
default_android_sdk_build_tools_version = "31.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this work with the agp in scenario app and background image tests?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tried it. Is the process to merge the PR in buildroot first, and then find out later while rolling to the engine?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we'll find out. It should fail now if there's a problem because we're not allowing Gradle to download arbitrary sdk components

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants