Bump Android version and add more info to create_sdk_cipd_package.sh #27413
Conversation
| echo "* When you change REPO_OS_OVERRIDE, you would also need to delete the directory from the" | ||
| echo "Android SDK location, so sdkmanager tries to download the binaries for the new platform." | ||
| echo "" | ||
| echo "For more see: https://developer.android.com/studio/command-line/sdkmanager" |
There was a problem hiding this comment.
Should we just create a script that does this?
There was a problem hiding this comment.
it's durable, although a better approach is to create a script similar to https://github.com/google/android-emulator-container-scripts/blob/318c3c2b73c66f91a77aef90aa8ded71649901f5/emu/emu_downloads_menu.py that parses the XML files with the assets, and then downloads the right stuff in the right place.
Given that this only occurs once a year, I'm not sure if we need this automation at the moment.
|
This change will need to wait for #27376 as bumping the version requires an update to the buildroot repo as well. |
|
The 31 SDK is still considered beta/first revision, do we have any guidelines/policies on what level of maturity is acceptable to upgrade Flutter to? |
|
If a feature is available on Android S only (e.g bold text) and the API changes in a way that it requires a patch, we can roll a new SDK and apply the patch. Similar to a Skia breaking change, etc. This is unlikely, but I don’t think it should block the implementation of the Android S features. |
GaryQian
left a comment
GaryQian
left a comment
There was a problem hiding this comment.
Ok, that sgtm, this LGTM then, pending buildroot merge.
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
LGTM as long as tests pass
|
Looks like there are linting issues at the least |
|
This is currently blocked on getting JDK 11 installed on the LUCI bots |
blasten
added
the
waiting for tree to go green
blasten
removed
the
waiting for tree to go green
|
The engine now depends on the JDK directly via gn dependencies. |
blasten
added
waiting for tree to go green
blasten
added
the
waiting for tree to go green
4 participants
Bumps Android's build-tools, platform-tools, and platforms packages.
Also, adds a bit more info to the script to help the next person doing the upgrade.