Skip to content

Conversation

@liyuqian
Copy link
Contributor

@liyuqian liyuqian commented Jan 19, 2021

Some part of this PR's code is from #788.

Related issue: flutter/flutter#73872

@liyuqian liyuqian requested a review from keyonghan January 19, 2021 18:34
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we document how to call this script?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentations added in aa59bda

liyuqian added a commit to liyuqian/cocoon that referenced this pull request Jan 19, 2021
@liyuqian liyuqian force-pushed the offline_transfer branch 2 times, most recently from f7a0129 to aa59bda Compare January 20, 2021 00:24
liyuqian added a commit that referenced this pull request Jan 20, 2021
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liyuqian liyuqian merged commit 4234ac4 into flutter:master Jan 21, 2021
liyuqian added a commit that referenced this pull request Jan 27, 2021
This needs #1061 and the `metrics_center` change in `pubspec.yaml` from #1060.

Once this PR is successfully deployed, we should be able to cut the dependency on Tong's desktop.
@liyuqian liyuqian deleted the offline_transfer branch January 27, 2021 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants