Let Cocoon write into metrics center #1062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyuqian
added a commit
to flutter/engine
that referenced
this pull request
Jan 20, 2021
This change shouldn't affect anything except for the "Linux benchmarks" LUCI post-submit bot. We'll closely monitor the LUCI bot to see if this works as intended. If so, we'll continue the migration in Cocoon (flutter/cocoon#1062) to cut the dependency on the old Cocoon datastore and Tong's desktop. Related issue: flutter/flutter#73872
liyuqian
force-pushed
the
migration
branch
2 times, most recently
from
4080a10 to
82ecfce
Compare
Contributor
Author
|
@keyonghan : I think this is now ready for review as flutter/engine#23767 has been successful on the engine side. |
keyonghan
approved these changes
Jan 25, 2021
Contributor
There was a problem hiding this comment.
can we add a doc briefly explain Metrics/flutter destination?
liyuqian
commented
Jan 25, 2021
Contributor
Author
liyuqian
left a comment
liyuqian
left a comment
There was a problem hiding this comment.
Thanks for the review! Docs added :)
keyonghan
reviewed
Jan 26, 2021
Contributor
There was a problem hiding this comment.
From the log, the error is DetailedApiRequestError, do you think we can use the exact error?
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
This change shouldn't affect anything except for the "Linux benchmarks" LUCI post-submit bot. We'll closely monitor the LUCI bot to see if this works as intended. If so, we'll continue the migration in Cocoon (flutter/cocoon#1062) to cut the dependency on the old Cocoon datastore and Tong's desktop. Related issue: flutter/flutter#73872
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs #1061 and the
metrics_centerchange inpubspec.yamlfrom #1060.Once this PR is successfully deployed, we should be able to cut the dependency on Tong's desktop.