This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Migrate to use the published metrics_center #23767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
zanderso
reviewed
Jan 20, 2021
testing/benchmark/pubspec.yaml
Outdated
| # flutter/packages, publish on pub.dev, and use the published package here. | ||
| git: https://github.com/liyuqian/metrics_center.git | ||
|
|
||
| metrics_center: ^0.0.4 |
Member
There was a problem hiding this comment.
Is there any risk of builds not being reproducible if this isn't pinned to a specific version?
Member
There was a problem hiding this comment.
builds or benchmark runs, that is.
Contributor
Author
There was a problem hiding this comment.
Probably. Now the version is pinned. Thanks for the suggestion!
zanderso
approved these changes
Jan 20, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 20, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 20, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 20, 2021
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
This change shouldn't affect anything except for the "Linux benchmarks" LUCI post-submit bot. We'll closely monitor the LUCI bot to see if this works as intended. If so, we'll continue the migration in Cocoon (flutter/cocoon#1062) to cut the dependency on the old Cocoon datastore and Tong's desktop. Related issue: flutter/flutter#73872
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change shouldn't affect anything except for the "Linux benchmarks" LUCI post-submit bot.
We'll closely monitor the LUCI bot to see if this works as intended. If so, we'll continue the migration in Cocoon (flutter/cocoon#1062) to cut the dependency on the old Cocoon datastore and Tong's desktop.
Related issue: flutter/flutter#73872