Allow for null responses from ServerConnectionStorage.getValue
#7374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Storage` interface already specifies that the return type should be nullable, but `ServerConnectionStorage` further restricted it to be non-nullable. If a key was looked up and it did not have an entry in storage, this would cause a type error and cause DevTools to hang on start in some situations. Fixes flutter#7373
bkonyi
requested review from
kenzieschmoll and
polina-c
and removed request for
a team
kenzieschmoll
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Storageinterface already specifies that the return type should be nullable, butServerConnectionStoragefurther restricted it to be non-nullable. If a key was looked up and it did not have an entry in storage, this would cause a type error and cause DevTools to hang on start in some situations.Fixes #7373
FYI @eliasyishak