Skip to content

Allow for null responses from ServerConnectionStorage.getValue #7374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bkonyi merged 1 commit into from
Mar 18, 2024
Merged

Allow for null responses from ServerConnectionStorage.getValue #7374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ls_app/lib/src/shared/config_specific/framework_initialize/_framework_initialize_web.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ class ServerConnectionStorage implements Storage {
final DevToolsServerConnection connection;

@override
Future<String> getValue(String key) {
Future<String?> getValue(String key) {
return connection.getPreferenceValue(key);
}

Expand Down
2 changes: 1 addition & 1 deletion packages/devtools_app/lib/src/shared/server/server_api_client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ class DevToolsServerConnection {

/// Retrieves a preference value from the DevTools configuration file at
/// ~/.flutter-devtools/.devtools.
Future<String> getPreferenceValue(String key) {
Future<String?> getPreferenceValue(String key) {
return _callMethod('getPreferenceValue', {
'key': key,
});
Expand Down