This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add isFocusable to SemanticsFlag #12618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b3f2aad.
gspencergoog
force-pushed
the
add_is_focusable
branch
from
dd9e885 to
c902c07
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 30, 2019
gspencergoog
added a commit
that referenced
this pull request
Sep 30, 2019
Adding missing flag for IsFocusable that I missed in #12618
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Sep 30, 2019
git@github.com:flutter/engine.git/compare/f0c77405d5c2...1f454c7 git log f0c7740..1f454c7 --no-merges --oneline 2019-09-30 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from sWs8N... to _0Sq8... (flutter/engine#12697) 2019-09-30 jason-simmons@users.noreply.github.com Migrate from fuchsia.crash.Analyzer to fuchsia.feedback.CrashReporter (flutter/engine#12413) 2019-09-30 gspencergoog@users.noreply.github.com Add isFocusable to SemanticsFlag (flutter/engine#12618) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
git@github.com:flutter/engine.git/compare/f0c77405d5c2...1f454c7 git log f0c7740..1f454c7 --no-merges --oneline 2019-09-30 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from sWs8N... to _0Sq8... (flutter/engine#12697) 2019-09-30 jason-simmons@users.noreply.github.com Migrate from fuchsia.crash.Analyzer to fuchsia.feedback.CrashReporter (flutter/engine#12413) 2019-09-30 gspencergoog@users.noreply.github.com Add isFocusable to SemanticsFlag (flutter/engine#12618) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an
isFocusabletoSemanticsFlagso that the framework can tell the engine what semantics nodes are allowed to be focused, which will affect what platform flags are applied to the semantics information.This flag is not yet in use by the framework.