Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@gspencergoog
Copy link
Contributor

Adding missing flag for IsFocusable that I missed in #12618

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gspencergoog gspencergoog removed the request for review from LongCatIsLooong September 30, 2019 18:09
@gspencergoog gspencergoog merged commit be9039e into flutter:master Sep 30, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 30, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Sep 30, 2019
git@github.com:flutter/engine.git/compare/1f454c75330c...9675ca2

git log 1f454c7..9675ca2 --no-merges --oneline
2019-09-30 liyuqian@google.com Reland "Smooth out iOS irregular input events delivery (#12280)" (flutter/engine#12385)
2019-09-30 gspencergoog@users.noreply.github.com Add missing flag for embedder. (flutter/engine#12700)
2019-09-30 lu.zuccarini@gmail.com Add a method to flutter_window_controller to destroy the current window. (flutter/engine#12076)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
git@github.com:flutter/engine.git/compare/1f454c75330c...9675ca2

git log 1f454c7..9675ca2 --no-merges --oneline
2019-09-30 liyuqian@google.com Reland "Smooth out iOS irregular input events delivery (flutter#12280)" (flutter/engine#12385)
2019-09-30 gspencergoog@users.noreply.github.com Add missing flag for embedder. (flutter/engine#12700)
2019-09-30 lu.zuccarini@gmail.com Add a method to flutter_window_controller to destroy the current window. (flutter/engine#12076)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants