Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Disable shell benchmarks #17038

Merged
liyuqian merged 1 commit into from
Mar 9, 2020
Merged

Disable shell benchmarks #17038

liyuqian merged 1 commit into from
Mar 9, 2020

Conversation

@liyuqian
Copy link
Contributor

@liyuqian liyuqian commented Mar 9, 2020

@auto-assign auto-assign bot requested a review from stuartmorgan-g March 9, 2020 21:10
@liyuqian
Copy link
Contributor Author

liyuqian commented Mar 9, 2020

Merge now to save other benchmarks.

@liyuqian liyuqian requested review from chinmaygarde and removed request for stuartmorgan-g March 9, 2020 21:12
@liyuqian liyuqian merged commit 1194ba2 into flutter:master Mar 9, 2020
@chinmaygarde
Copy link
Contributor

chinmaygarde commented Mar 9, 2020

lgtm

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2020
@engine-flutter-autoroll
1194ba2 Disable shell benchmarks (flutter/engine#17038)
2c6f977
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2020
Closed
blasten pushed a commit to blasten/engine that referenced this pull request Mar 10, 2020
@liyuqian
Disable shell benchmarks (flutter#17038)
ca28dc4 
See flutter/flutter#52263

TBR: @chinmaygarde
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2020
@engine-flutter-autoroll
1194ba2 Disable shell benchmarks (flutter/engine#17038)
4f10476
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2020
@engine-flutter-autoroll
1194ba2 Disable shell benchmarks (flutter/engine#17038)
9adcd5e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2020
@engine-flutter-autoroll
1194ba2 Disable shell benchmarks (flutter/engine#17038)
5cddfab
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2020
@engine-flutter-autoroll
1194ba2 Disable shell benchmarks (flutter/engine#17038)
fa5c25c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2020
@engine-flutter-autoroll
1194ba2 Disable shell benchmarks (flutter/engine#17038)
51562ce
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2020
@engine-flutter-autoroll
1194ba2 Disable shell benchmarks (flutter/engine#17038)
578c364
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2020
@engine-flutter-autoroll
1194ba2 Disable shell benchmarks (flutter/engine#17038)
39859c9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2020
@engine-flutter-autoroll
1194ba2 Disable shell benchmarks (flutter/engine#17038)
bb77e1a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
1194ba2 Disable shell benchmarks (flutter/engine#17038)
b6b738f
This was referenced Mar 11, 2020
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
1194ba2 Disable shell benchmarks (flutter/engine#17038)
5608cdc
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
1194ba2 Disable shell benchmarks (flutter/engine#17038)
e3a3934
This was referenced Mar 11, 2020
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
1194ba2 Disable shell benchmarks (flutter/engine#17038)
6007dda
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
1194ba2 Disable shell benchmarks (flutter/engine#17038)
b490db8
This was referenced Mar 11, 2020
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
1194ba2 Disable shell benchmarks (flutter/engine#17038)
cfc2417
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
1194ba2 Disable shell benchmarks (flutter/engine#17038)
81ea4de
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
1194ba2 Disable shell benchmarks (flutter/engine#17038)
646d8a5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
1194ba2 Disable shell benchmarks (flutter/engine#17038)
49e4a02
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
1194ba2 Disable shell benchmarks (flutter/engine#17038)
e09455c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2020
Closed
jason-simmons added a commit to jason-simmons/flutter that referenced this pull request Mar 11, 2020
@jason-simmons
Manual roll engine 0e2c8fe..6d8611d (31 commits)
449aea9 
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/dart 4093d08271f6..37530145ff53 (4 commits) (flutter/engine#17090)
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia bf355123ae3b..0340292972b9 (9 commits) (flutter/engine#17089)
2020-03-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from r_oCI... to 0Z8VF... (flutter/engine#17087)
2020-03-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from v32mJ... to X3Xm2... (flutter/engine#17086)
2020-03-11 chinmaygarde@gmail.com Remove the unused method on iOS surface to make the resource context current. (flutter/engine#17084)
2020-03-11 chinmaygarde@gmail.com Revert "Add support for the Metal backend on all iOS builds. (flutter#17080)" (flutter/engine#17088)
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/dart ace1d9b9213a..4093d08271f6 (12 commits) (flutter/engine#17082)
2020-03-11 chinmaygarde@google.com Add support for the Metal backend on all iOS builds. (flutter/engine#17080)
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia d3f67dbf9f36..bf355123ae3b (9 commits) (flutter/engine#17079)
2020-03-11 chinmaygarde@google.com Disable Embedder11yTest::A11yTreeIsConsistent to unblock LUCI. (flutter/engine#17081)
2020-03-10 chinmaygarde@google.com Gather demangled stack traces and report the same to console on crashes. (flutter/engine#16450)
2020-03-10 chinmaygarde@google.com Implement asynchronous texture uploads when using the Metal backend on iOS. (flutter/engine#17046)
2020-03-10 skia-flutter-autoroll@skia.org Roll src/third_party/dart 97674262bc29..ace1d9b9213a (14 commits) (flutter/engine#17078)
2020-03-10 egarciad@google.com Add RTree to flow (flutter/engine#16923)
2020-03-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 78dac6dcb222..d3f67dbf9f36 (6 commits) (flutter/engine#17072)
2020-03-10 flar@google.com Revert "Fix bounds of image_filter_layer (flutter#16960)" (flutter/engine#17074)
2020-03-10 chinmaygarde@google.com Use the ELF loader to setup AOT symbols in benchmark runner. (flutter/engine#17051)
2020-03-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 23899c64e3db..78dac6dcb222 (19 commits) (flutter/engine#17069)
2020-03-10 aam@google.com Roll dart to 97674262bc29447dc59d5c93024b18b27d4bcf98. (flutter/engine#17067)
2020-03-10 ferhat@gmail.com [web] Fixes for Firefox & Safari double underline decoration bugs. (flutter/engine#16994)
2020-03-10 dnfield@google.com Avoid capturing this unsafely in MultiFrameCodec (flutter/engine#16824)
2020-03-10 yjbanov@google.com Revert "Revert "fix shadows and mask filter blurs (flutter#16963)" (flutter#17008)" (flutter/engine#17040)
2020-03-10 ferhat@gmail.com Add support for firefox mac installer. Update web_ui pubspec for http.wq (flutter/engine#17044)
2020-03-09 yjbanov@google.com fix "TREE INCONSISTENT" noise in compositing_test.dart (flutter/engine#16995)
2020-03-09 yjbanov@google.com Add more child lifecycle tests (flutter/engine#16689)
2020-03-09 chris@bracken.jp Add libfreetype6-dev to desktop Linux dependencies (flutter/engine#17020)
2020-03-09 liyuqian@google.com Disable shell benchmarks (flutter/engine#17038)
2020-03-09 flar@google.com Fix bounds of image_filter_layer (flutter/engine#16960)
2020-03-09 liyuqian@google.com Record fml and shell benchmarks (flutter/engine#16991)
2020-03-09 skia-flutter-autoroll@skia.org Roll src/third_party/skia c56950442dd1..23899c64e3db (11 commits) (flutter/engine#17033)
2020-03-09 yjbanov@google.com use commit date instead of author date (flutter/engine#17032)
@jason-simmons jason-simmons mentioned this pull request Mar 11, 2020
Merged
13 tasks
jason-simmons added a commit to flutter/flutter that referenced this pull request Mar 11, 2020
@jason-simmons
Manual roll engine 0e2c8fe..6d8611d (31 commits) (#52431)
5e74b00 
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/dart 4093d08271f6..37530145ff53 (4 commits) (flutter/engine#17090)
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia bf355123ae3b..0340292972b9 (9 commits) (flutter/engine#17089)
2020-03-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from r_oCI... to 0Z8VF... (flutter/engine#17087)
2020-03-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from v32mJ... to X3Xm2... (flutter/engine#17086)
2020-03-11 chinmaygarde@gmail.com Remove the unused method on iOS surface to make the resource context current. (flutter/engine#17084)
2020-03-11 chinmaygarde@gmail.com Revert "Add support for the Metal backend on all iOS builds. (#17080)" (flutter/engine#17088)
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/dart ace1d9b9213a..4093d08271f6 (12 commits) (flutter/engine#17082)
2020-03-11 chinmaygarde@google.com Add support for the Metal backend on all iOS builds. (flutter/engine#17080)
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia d3f67dbf9f36..bf355123ae3b (9 commits) (flutter/engine#17079)
2020-03-11 chinmaygarde@google.com Disable Embedder11yTest::A11yTreeIsConsistent to unblock LUCI. (flutter/engine#17081)
2020-03-10 chinmaygarde@google.com Gather demangled stack traces and report the same to console on crashes. (flutter/engine#16450)
2020-03-10 chinmaygarde@google.com Implement asynchronous texture uploads when using the Metal backend on iOS. (flutter/engine#17046)
2020-03-10 skia-flutter-autoroll@skia.org Roll src/third_party/dart 97674262bc29..ace1d9b9213a (14 commits) (flutter/engine#17078)
2020-03-10 egarciad@google.com Add RTree to flow (flutter/engine#16923)
2020-03-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 78dac6dcb222..d3f67dbf9f36 (6 commits) (flutter/engine#17072)
2020-03-10 flar@google.com Revert "Fix bounds of image_filter_layer (#16960)" (flutter/engine#17074)
2020-03-10 chinmaygarde@google.com Use the ELF loader to setup AOT symbols in benchmark runner. (flutter/engine#17051)
2020-03-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 23899c64e3db..78dac6dcb222 (19 commits) (flutter/engine#17069)
2020-03-10 aam@google.com Roll dart to 97674262bc29447dc59d5c93024b18b27d4bcf98. (flutter/engine#17067)
2020-03-10 ferhat@gmail.com [web] Fixes for Firefox & Safari double underline decoration bugs. (flutter/engine#16994)
2020-03-10 dnfield@google.com Avoid capturing this unsafely in MultiFrameCodec (flutter/engine#16824)
2020-03-10 yjbanov@google.com Revert "Revert "fix shadows and mask filter blurs (#16963)" (#17008)" (flutter/engine#17040)
2020-03-10 ferhat@gmail.com Add support for firefox mac installer. Update web_ui pubspec for http.wq (flutter/engine#17044)
2020-03-09 yjbanov@google.com fix "TREE INCONSISTENT" noise in compositing_test.dart (flutter/engine#16995)
2020-03-09 yjbanov@google.com Add more child lifecycle tests (flutter/engine#16689)
2020-03-09 chris@bracken.jp Add libfreetype6-dev to desktop Linux dependencies (flutter/engine#17020)
2020-03-09 liyuqian@google.com Disable shell benchmarks (flutter/engine#17038)
2020-03-09 flar@google.com Fix bounds of image_filter_layer (flutter/engine#16960)
2020-03-09 liyuqian@google.com Record fml and shell benchmarks (flutter/engine#16991)
2020-03-09 skia-flutter-autoroll@skia.org Roll src/third_party/skia c56950442dd1..23899c64e3db (11 commits) (flutter/engine#17033)
2020-03-09 yjbanov@google.com use commit date instead of author date (flutter/engine#17032)
@liyuqian liyuqian deleted the disable_shell_benchmark branch May 8, 2020 21:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liyuqian @chinmaygarde @googlebot