Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Use the ELF loader to setup AOT symbols in benchmark runner. #17051

Merged
chinmaygarde merged 1 commit into from
Mar 10, 2020
Merged

Use the ELF loader to setup AOT symbols in benchmark runner. #17051

chinmaygarde merged 1 commit into from
Mar 10, 2020

Conversation

@chinmaygarde
Copy link
Contributor

@chinmaygarde chinmaygarde commented Mar 10, 2020

We no longer package AOT artifacts as discrete blobs. The portable ELF loader
from the testing library may be used instead.

Fixes flutter/flutter#52263

@chinmaygarde chinmaygarde requested a review from liyuqian March 10, 2020 03:10
@chinmaygarde chinmaygarde mentioned this pull request Mar 10, 2020
Closed
liyuqian
liyuqian approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@liyuqian liyuqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix! Nit: maybe also add the following section to .cirrus.yml (or its LUCI counterpart) so we can check release mode shell_benchmarks in presubmit tests:

    - name: build_and_test_linux_release
      compile_host_script: |
        cd $ENGINE_PATH/src
        ./flutter/tools/gn --runtime-mode=release
        ninja -C out/host_release
      test_host_script: |
        cd $ENGINE_PATH/src
        ./flutter/testing/run_tests.sh host_release

@chinmaygarde
Copy link
Contributor Author

chinmaygarde commented Mar 10, 2020

I am not sure I want to start building an entire engine variant just to run a benchmark whose results we won't collect. I'll see if the profile stuff will work instead.

@chinmaygarde
Copy link
Contributor Author

chinmaygarde commented Mar 10, 2020

Oh. I see what you meant. Won't this be checked implicitly when parse_and_send.dart is used to collect this benchmark?

@chinmaygarde
Use the ELF loader to setup AOT symbols in benchmark runner.
b5d8096 
We no longer package AOT artifacts as discrete blobs. The portable ELF loader
from the testing library may be used instead.

Fixes flutter/flutter#52263
@chinmaygarde chinmaygarde added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 10, 2020
@liyuqian
Copy link
Contributor

liyuqian commented Mar 10, 2020

@chinmaygarde : the build_and_benchmark_linux_release tasks only runs in post-submit (only_if: $CIRRUS_BRANCH == 'master'). That's why I suggest creating another task build_and_test_linux_release without the only_if condition. Such task also does more test in release mode than just benchmarks since it's using ./flutter/testing/run_tests.sh host_release instead of triggering benchmarks individually.

@chinmaygarde
Copy link
Contributor Author

chinmaygarde commented Mar 10, 2020

Roger. I will patch that separately after I shepherd another patch to master.

@chinmaygarde chinmaygarde merged commit bcefcdb into flutter:master Mar 10, 2020
@chinmaygarde chinmaygarde deleted the bench_aot branch March 10, 2020 19:28
@liyuqian
Copy link
Contributor

liyuqian commented Mar 10, 2020

@chinmaygarde : no worry, I can also do that: #17073

@chinmaygarde
Copy link
Contributor Author

chinmaygarde commented Mar 10, 2020

Thanks. I appreciate it.

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2020
@engine-flutter-autoroll
bcefcdb Use the ELF loader to setup AOT symbols in benchmark runner. (f…
6140a86 
…lutter/engine#17051)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
bcefcdb Use the ELF loader to setup AOT symbols in benchmark runner. (f…
123a90b 
…lutter/engine#17051)
This was referenced Mar 11, 2020
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
bcefcdb Use the ELF loader to setup AOT symbols in benchmark runner. (f…
c14b37e 
…lutter/engine#17051)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
bcefcdb Use the ELF loader to setup AOT symbols in benchmark runner. (f…
30502b8 
…lutter/engine#17051)
This was referenced Mar 11, 2020
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
bcefcdb Use the ELF loader to setup AOT symbols in benchmark runner. (f…
d11b8c6 
…lutter/engine#17051)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
bcefcdb Use the ELF loader to setup AOT symbols in benchmark runner. (f…
eb053c8 
…lutter/engine#17051)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
bcefcdb Use the ELF loader to setup AOT symbols in benchmark runner. (f…
515f786 
…lutter/engine#17051)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
bcefcdb Use the ELF loader to setup AOT symbols in benchmark runner. (f…
0973e61 
…lutter/engine#17051)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
bcefcdb Use the ELF loader to setup AOT symbols in benchmark runner. (f…
e94734f 
…lutter/engine#17051)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
bcefcdb Use the ELF loader to setup AOT symbols in benchmark runner. (f…
be9b67c 
…lutter/engine#17051)
This was referenced Mar 11, 2020
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
bcefcdb Use the ELF loader to setup AOT symbols in benchmark runner. (f…
a280d10 
…lutter/engine#17051)
jason-simmons added a commit to jason-simmons/flutter that referenced this pull request Mar 11, 2020
@jason-simmons
Manual roll engine 0e2c8fe..6d8611d (31 commits)
449aea9 
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/dart 4093d08271f6..37530145ff53 (4 commits) (flutter/engine#17090)
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia bf355123ae3b..0340292972b9 (9 commits) (flutter/engine#17089)
2020-03-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from r_oCI... to 0Z8VF... (flutter/engine#17087)
2020-03-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from v32mJ... to X3Xm2... (flutter/engine#17086)
2020-03-11 chinmaygarde@gmail.com Remove the unused method on iOS surface to make the resource context current. (flutter/engine#17084)
2020-03-11 chinmaygarde@gmail.com Revert "Add support for the Metal backend on all iOS builds. (flutter#17080)" (flutter/engine#17088)
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/dart ace1d9b9213a..4093d08271f6 (12 commits) (flutter/engine#17082)
2020-03-11 chinmaygarde@google.com Add support for the Metal backend on all iOS builds. (flutter/engine#17080)
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia d3f67dbf9f36..bf355123ae3b (9 commits) (flutter/engine#17079)
2020-03-11 chinmaygarde@google.com Disable Embedder11yTest::A11yTreeIsConsistent to unblock LUCI. (flutter/engine#17081)
2020-03-10 chinmaygarde@google.com Gather demangled stack traces and report the same to console on crashes. (flutter/engine#16450)
2020-03-10 chinmaygarde@google.com Implement asynchronous texture uploads when using the Metal backend on iOS. (flutter/engine#17046)
2020-03-10 skia-flutter-autoroll@skia.org Roll src/third_party/dart 97674262bc29..ace1d9b9213a (14 commits) (flutter/engine#17078)
2020-03-10 egarciad@google.com Add RTree to flow (flutter/engine#16923)
2020-03-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 78dac6dcb222..d3f67dbf9f36 (6 commits) (flutter/engine#17072)
2020-03-10 flar@google.com Revert "Fix bounds of image_filter_layer (flutter#16960)" (flutter/engine#17074)
2020-03-10 chinmaygarde@google.com Use the ELF loader to setup AOT symbols in benchmark runner. (flutter/engine#17051)
2020-03-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 23899c64e3db..78dac6dcb222 (19 commits) (flutter/engine#17069)
2020-03-10 aam@google.com Roll dart to 97674262bc29447dc59d5c93024b18b27d4bcf98. (flutter/engine#17067)
2020-03-10 ferhat@gmail.com [web] Fixes for Firefox & Safari double underline decoration bugs. (flutter/engine#16994)
2020-03-10 dnfield@google.com Avoid capturing this unsafely in MultiFrameCodec (flutter/engine#16824)
2020-03-10 yjbanov@google.com Revert "Revert "fix shadows and mask filter blurs (flutter#16963)" (flutter#17008)" (flutter/engine#17040)
2020-03-10 ferhat@gmail.com Add support for firefox mac installer. Update web_ui pubspec for http.wq (flutter/engine#17044)
2020-03-09 yjbanov@google.com fix "TREE INCONSISTENT" noise in compositing_test.dart (flutter/engine#16995)
2020-03-09 yjbanov@google.com Add more child lifecycle tests (flutter/engine#16689)
2020-03-09 chris@bracken.jp Add libfreetype6-dev to desktop Linux dependencies (flutter/engine#17020)
2020-03-09 liyuqian@google.com Disable shell benchmarks (flutter/engine#17038)
2020-03-09 flar@google.com Fix bounds of image_filter_layer (flutter/engine#16960)
2020-03-09 liyuqian@google.com Record fml and shell benchmarks (flutter/engine#16991)
2020-03-09 skia-flutter-autoroll@skia.org Roll src/third_party/skia c56950442dd1..23899c64e3db (11 commits) (flutter/engine#17033)
2020-03-09 yjbanov@google.com use commit date instead of author date (flutter/engine#17032)
@jason-simmons jason-simmons mentioned this pull request Mar 11, 2020
Merged
13 tasks
jason-simmons added a commit to flutter/flutter that referenced this pull request Mar 11, 2020
@jason-simmons
Manual roll engine 0e2c8fe..6d8611d (31 commits) (#52431)
5e74b00 
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/dart 4093d08271f6..37530145ff53 (4 commits) (flutter/engine#17090)
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia bf355123ae3b..0340292972b9 (9 commits) (flutter/engine#17089)
2020-03-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from r_oCI... to 0Z8VF... (flutter/engine#17087)
2020-03-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from v32mJ... to X3Xm2... (flutter/engine#17086)
2020-03-11 chinmaygarde@gmail.com Remove the unused method on iOS surface to make the resource context current. (flutter/engine#17084)
2020-03-11 chinmaygarde@gmail.com Revert "Add support for the Metal backend on all iOS builds. (#17080)" (flutter/engine#17088)
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/dart ace1d9b9213a..4093d08271f6 (12 commits) (flutter/engine#17082)
2020-03-11 chinmaygarde@google.com Add support for the Metal backend on all iOS builds. (flutter/engine#17080)
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia d3f67dbf9f36..bf355123ae3b (9 commits) (flutter/engine#17079)
2020-03-11 chinmaygarde@google.com Disable Embedder11yTest::A11yTreeIsConsistent to unblock LUCI. (flutter/engine#17081)
2020-03-10 chinmaygarde@google.com Gather demangled stack traces and report the same to console on crashes. (flutter/engine#16450)
2020-03-10 chinmaygarde@google.com Implement asynchronous texture uploads when using the Metal backend on iOS. (flutter/engine#17046)
2020-03-10 skia-flutter-autoroll@skia.org Roll src/third_party/dart 97674262bc29..ace1d9b9213a (14 commits) (flutter/engine#17078)
2020-03-10 egarciad@google.com Add RTree to flow (flutter/engine#16923)
2020-03-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 78dac6dcb222..d3f67dbf9f36 (6 commits) (flutter/engine#17072)
2020-03-10 flar@google.com Revert "Fix bounds of image_filter_layer (#16960)" (flutter/engine#17074)
2020-03-10 chinmaygarde@google.com Use the ELF loader to setup AOT symbols in benchmark runner. (flutter/engine#17051)
2020-03-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 23899c64e3db..78dac6dcb222 (19 commits) (flutter/engine#17069)
2020-03-10 aam@google.com Roll dart to 97674262bc29447dc59d5c93024b18b27d4bcf98. (flutter/engine#17067)
2020-03-10 ferhat@gmail.com [web] Fixes for Firefox & Safari double underline decoration bugs. (flutter/engine#16994)
2020-03-10 dnfield@google.com Avoid capturing this unsafely in MultiFrameCodec (flutter/engine#16824)
2020-03-10 yjbanov@google.com Revert "Revert "fix shadows and mask filter blurs (#16963)" (#17008)" (flutter/engine#17040)
2020-03-10 ferhat@gmail.com Add support for firefox mac installer. Update web_ui pubspec for http.wq (flutter/engine#17044)
2020-03-09 yjbanov@google.com fix "TREE INCONSISTENT" noise in compositing_test.dart (flutter/engine#16995)
2020-03-09 yjbanov@google.com Add more child lifecycle tests (flutter/engine#16689)
2020-03-09 chris@bracken.jp Add libfreetype6-dev to desktop Linux dependencies (flutter/engine#17020)
2020-03-09 liyuqian@google.com Disable shell benchmarks (flutter/engine#17038)
2020-03-09 flar@google.com Fix bounds of image_filter_layer (flutter/engine#16960)
2020-03-09 liyuqian@google.com Record fml and shell benchmarks (flutter/engine#16991)
2020-03-09 skia-flutter-autoroll@skia.org Roll src/third_party/skia c56950442dd1..23899c64e3db (11 commits) (flutter/engine#17033)
2020-03-09 yjbanov@google.com use commit date instead of author date (flutter/engine#17032)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@liyuqian liyuqian liyuqian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

shell_benchmarks failed to run in the release mode

3 participants

@chinmaygarde @liyuqian @googlebot