This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix exactCullRect computation #24651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
yjbanov
approved these changes
Feb 26, 2021
| } | ||
|
|
||
| @override | ||
| Matrix4 get localTransformInverse => |
Contributor
There was a problem hiding this comment.
Should this getter be renamed?
ferhatb
changed the title
mdebbar
reviewed
Mar 3, 2021
Comment on lines
24
to
26
| Matrix4? get localTransform { | ||
| _localTransform ??= Matrix4.fromFloat32List(matrix4); | ||
| return _localTransform; |
Contributor
There was a problem hiding this comment.
You could also use late final here:
late final localTransform = Matrix4.fromFloat32List(matrix4);
| test( | ||
| 'skips painting picture when picture fully clipped out with transform and offset', () async { | ||
| final Picture picture = _drawPicture(); | ||
| // Picture should not be clipped out since transform will offset it to 500,500 |
Contributor
Author
|
Split this PR up. Part1 went into #25080 |
ferhatb
changed the title
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 25, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 25, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 25, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 26, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 26, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 29, 2021
chandarrengoog
pushed a commit
to chandarrengoog/engine
that referenced
this pull request
Mar 30, 2021
duanqz
pushed a commit
to duanqz/engine
that referenced
this pull request
Apr 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed disappearing surfaces due to non-homogenous matrix breaking cull rect computation.
flutter/flutter#59392
Pre-launch Checklist
writing and running engine tests.
///).