Treat clang-analyzer-osx warnings as errors

[jmagman]

There are no clang-analyzer-osx warnings in the iOS or macOS embedder as of #29623. Make the clang-tidy linter treat these warnings as errors so they show up locally during pre-push git hook linter.

Note this still isn't running in CI for due to flutter/flutter#61661 (comment).

Pre-submit part of flutter/flutter#93279

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
• I listed at least one issue that this PR fixes in the description above.
• I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
  writing and running engine tests.
• I updated/added relevant documentation (doc comments with ///).
• I signed the CLA.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[zanderso]

Does this file allow comments? If so, we should link to a tracking issue.

[dnfield]

Per https://clang.llvm.org/extra/clang-tidy/ it looks like this is YAML, so # should work for comments.

[jmagman]

Done.