Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Treat clang-analyzer-osx warnings as errors #29755

Merged
fluttergithubbot merged 2 commits into from
Nov 16, 2021
Merged

Treat clang-analyzer-osx warnings as errors #29755

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52a5fe0
Turn on clang-analyzer-osx errors
jmagman Nov 15, 2021
d3a1d5d
Add comment
jmagman Nov 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .clang-tidy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,8 @@
Checks: 'google-*'

# Only warnings treated as errors are reported
# in the "ci/lint.sh" script and pre-push git hook.
# Add checks when all warnings are fixed
# to prevent new warnings from being introduced.
# https://github.com/flutter/flutter/issues/93279
WarningsAsErrors: 'clang-analyzer-osx.*'
Copy link
Member

@zanderso zanderso Nov 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this file allow comments? If so, we should link to a tracking issue.

Copy link
Contributor

@dnfield dnfield Nov 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per https://clang.llvm.org/extra/clang-tidy/ it looks like this is YAML, so # should work for comments.

Copy link
Member Author

@jmagman jmagman Nov 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.