This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Disable several tests due to flakiness #32059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 16, 2022
chinmaygarde
previously requested changes
Mar 16, 2022
Contributor
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
Per the linked issue, @iskakaushik is going to take a shot at disabling these. Let's hold on disabling these just yet.
Contributor
|
@chinmaygarde, I tried to reproduce this for a while today. Found a couple of data races:
Let us disable this for now. I'll re-investigate when I have more cycles. |
iskakaushik
reviewed
Mar 16, 2022
shell/common/shell_unittests.cc
Outdated
| DestroyShell(std::move(shell)); | ||
| } | ||
|
|
||
| // TODO(https://github.com/flutter/flutter/issues/95751): Disabled due to |
Contributor
There was a problem hiding this comment.
Could you please file a new issue to re-enable these tests and link it here? That way we still have an open issue to re-enable the tests. Thanks.
Member
Author
(The requested change has been addressed) |
ColdPaleLight
dismissed
chinmaygarde’s stale review
The requested change has been addressed
ColdPaleLight
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 17, 2022
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 17, 2022
* 7fe613a Roll Dart SDK from 5bc905e69609 to ad5a250935d5 (4 revisions) (flutter/engine#32079) * 3a954ba Disable several tests due to flakiness (flutter/engine#32059) * 05bba9b [web] Log all goldctl commands (flutter/engine#32072) * 86b2c8d Roll Skia from 9301fe3779bb to 02ebd1a23381 (4 revisions) (flutter/engine#32067) * abb1bce Roll Fuchsia Linux SDK from mVqiTwaVa... to RAyopISUl... (flutter/engine#32069) * 481f4bc Roll Fuchsia Mac SDK from vWlaMIVkM... to -JEG0j8mn... (flutter/engine#32077) * 560243c Roll Dart SDK from ad5a250935d5 to 5168cdd236a0 (1 revision) (flutter/engine#32081) * e2e6b49 Roll Skia from 02ebd1a23381 to 5e035c66da3c (19 revisions) (flutter/engine#32082) * e4056c5 ensure _futurize does not leak uncaught errors into the zone (flutter/engine#32070)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue: flutter/flutter#95751
Pre-launch Checklist
writing and running engine tests.
///).