[web] Log all goldctl commands #32072
Conversation
flutter-dashboard
bot
added
the
platform-web
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Gold has detected about 18 new digest(s) on patchset 1. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
LGTM, this improves traceability of a script.
* 7fe613a Roll Dart SDK from 5bc905e69609 to ad5a250935d5 (4 revisions) (flutter/engine#32079) * 3a954ba Disable several tests due to flakiness (flutter/engine#32059) * 05bba9b [web] Log all goldctl commands (flutter/engine#32072) * 86b2c8d Roll Skia from 9301fe3779bb to 02ebd1a23381 (4 revisions) (flutter/engine#32067) * abb1bce Roll Fuchsia Linux SDK from mVqiTwaVa... to RAyopISUl... (flutter/engine#32069) * 481f4bc Roll Fuchsia Mac SDK from vWlaMIVkM... to -JEG0j8mn... (flutter/engine#32077) * 560243c Roll Dart SDK from ad5a250935d5 to 5168cdd236a0 (1 revision) (flutter/engine#32081) * e2e6b49 Roll Skia from 02ebd1a23381 to 5e035c66da3c (19 revisions) (flutter/engine#32082) * e4056c5 ensure _futurize does not leak uncaught errors into the zone (flutter/engine#32070)
3 participants
Very simple PR to add logging for all
goldctlcommands. This makes investigating future issues easier.A recent issue that would've benefited from extra logging: #32071