Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@flar
Copy link
Contributor

@flar flar commented Mar 17, 2022

Fixes flutter/flutter#100305

Override the delete operators in the DlGradient classes since they were allocated manually with the new operator with a custom size.

The non-sized variant delete(p) is called during our engine unit tests, but apparently the sized version is called in some downstream tests so both are implemented.

Copy link
Contributor

@chinmaygarde chinmaygarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no guidance to provide on how to test this besides using a different allocator. I believe you already mentioned in chat that you tried with ASAN.

@flar flar added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 17, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flar
Copy link
Contributor Author

flar commented Mar 17, 2022

WRT the dashboard comment above about missing tests - we do not use an allocator that generates this error in our engine tests.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs tests waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Memory management crash in DL

2 participants