Skip to content

Some of our environments prefer sized deletes, others don't support it #100327

@flar

Description

@flar

In (permalink once flutter/engine#32088 lands needed) we need to supply a Deleter for our shared_ptr because it was allocated with an unexpected size. If we do not, then we get build failures downstream in environments that check for consistency between the new and delete operators.

We can supply a Deleter that calls the specific sized delete with the right size, which would be faster on those platforms, but unfortunately at least one environment (iOS) uses an allocator that does not provide the sized delete.

When all of our environments support sized deletes then we can provide the proper size.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Issues that are less important to the Flutter projectc: proposalA detailed proposal for a change to Flutterengineflutter/engine related. See also e: labels.team-engineOwned by Engine teamtriaged-engineTriaged by Engine team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions