This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Android] Synchronize incorrect metaState using post-synchronization #34827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 22, 2022
8 tasks
This was referenced Sep 2, 2022
Closed
Merged
8 tasks
itsjustkevin
pushed a commit
that referenced
this pull request
Sep 20, 2022
…ting text in `TextField` (#36288) * [Android] Synchronize incorrect metaState using post-synchronization (#34827) (cherry picked from commit a56d98e) * [Android] Fix a crash related to zeroed scanCode (#35924) (cherry picked from commit fe5b84a) Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com> Co-authored-by: Bruno Leroux <leroux_bruno@yahoo.fr>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#108124.
The Android platform might dispatch a ShiftLeft key down event with SHIFT metaState 0. In order to resolve this conflict, this PR synthesizes a ShiftLeft up after the main event in such cases.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.