Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@AlexV525
Copy link
Member

Cherry picks #34827 and #35924.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@skia-gold
Copy link

Gold has detected about 1 new digest(s) on patchset 2.
View them at https://flutter-engine-gold.skia.org/cl/github/36288

Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cherry pick LGTM 👍

Is the Gold bot comment above a flake? I can't view the failure(s) at that link, there is an error. CC @Piinks

@Piinks
Copy link
Contributor

Piinks commented Sep 20, 2022

#34827 and #35924 did not introduce Gold changes from what I can tell. @mdebbar is more familiar with the engine goldens than I am, in case you are more familiar with this case, have you seen this before?

image

@itsjustkevin itsjustkevin merged commit 7224093 into flutter:flutter-3.2-candidate.5 Sep 20, 2022
@AlexV525 AlexV525 deleted the cp-android-key-post-synchronize branch September 21, 2022 00:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants