This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Remove the 'write' parameter from golden methods #36095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was opened against a branch other than main. Since Flutter pull requests should not normally be opened against branches other than main, I have changed the base to main. If this was intended, you may modify the base back to master. See the Release Process for information about how other branches get updated. Reviewers: Use caution before merging pull requests to branches other than main, unless this is an intentional hotfix/cherrypick. |
flutter-dashboard
bot
added
the
platform-web
mdebbar
force-pushed
the
remove_golden_write
branch
from
ac6fecf to
ac6a711
Compare
yjbanov
approved these changes
Sep 12, 2022
| Future<String> _diffScreenshot( | ||
| String filename, | ||
| bool write, | ||
| double maxDiffRateFailure, |
Contributor
There was a problem hiding this comment.
Do we still use the "max diff rate" arguments for anything?
Contributor
Author
There was a problem hiding this comment.
There are several things I want to clean up in our golden tests. I'll add max diff rate to the list.
mdebbar
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 13, 2022
cfontas
pushed a commit
to cfontas/engine
that referenced
this pull request
Sep 14, 2022
Oleh-Sv
pushed a commit
to Oleh-Sv/engine
that referenced
this pull request
Sep 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
writeparameter is a remnant from the old way we used to do golden tests. It is used to selectively "update" a golden.We are removing it in favor of the (already existent)
update-screenshot-goldensflag that updates all goldens at once.The flag and the
writeparameter are currently no-ops because we moved to Skia Gold which stores and updates goldens in post-submit. That said, we will likely re-introduce local golden testing, and for that we need these flags.